From 9d8cc49b0f6c3b6d0b5c46dae665fee7c7cb7b42 Mon Sep 17 00:00:00 2001 From: Isaiah Paget <113209222+IsaiahPaget@users.noreply.github.com> Date: Sat, 6 Apr 2024 12:01:45 -0700 Subject: [PATCH 1/2] fixed no type inference using for in loop --- src/server/analysis.odin | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/analysis.odin b/src/server/analysis.odin index 81f2df9b..6dfe394a 100644 --- a/src/server/analysis.odin +++ b/src/server/analysis.odin @@ -3185,7 +3185,7 @@ get_locals_for_range_stmt :: proc( ) { using ast - if !(stmt.body.pos.offset <= document_position.position && + if !(stmt.body.pos.offset >= document_position.position && document_position.position <= stmt.body.end.offset) { return } From 1ccd0be3ddce668cbdc7f11949477f30a90ca2fb Mon Sep 17 00:00:00 2001 From: Isaiah Paget <113209222+IsaiahPaget@users.noreply.github.com> Date: Sun, 7 Apr 2024 10:29:35 -0700 Subject: [PATCH 2/2] changed condition in analysis.odin that was affecting type inference in for range stmt --- src/server/analysis.odin | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/analysis.odin b/src/server/analysis.odin index 6b9f2531..877125fe 100644 --- a/src/server/analysis.odin +++ b/src/server/analysis.odin @@ -3185,8 +3185,8 @@ get_locals_for_range_stmt :: proc( ) { using ast - if !(stmt.body.pos.offset >= document_position.position && - document_position.position <= stmt.body.end.offset) { + if !(stmt.pos.offset <= document_position.position && + document_position.position <= stmt.end.offset) { return }