From d49d1bdfa2e5e2b8df0996d07c43ec7d7b8fdb6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Sun, 26 Feb 2023 22:00:30 +0100 Subject: [PATCH] Add some asserts for things that are always true --- .../_configuration/boolean_option_action.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pydocstringformatter/_configuration/boolean_option_action.py b/pydocstringformatter/_configuration/boolean_option_action.py index 41d90827..1d20b08d 100644 --- a/pydocstringformatter/_configuration/boolean_option_action.py +++ b/pydocstringformatter/_configuration/boolean_option_action.py @@ -27,17 +27,17 @@ def __init__( # Non-argparse changes assert help, "All BooleanOptionalAction's should have a help message." - # Rest of implementation directly copied from argparse + # Rest of implementation directly copied from argparse, expect for the asserts _option_strings = [] for option_string in option_strings: _option_strings.append(option_string) - if option_string.startswith("--"): - option_string = "--no-" + option_string[2:] - _option_strings.append(option_string) + assert option_string.startswith("--") + option_string = "--no-" + option_string[2:] + _option_strings.append(option_string) - if help is not None and default is not None: - help += " (default: %(default)s)" + assert help is not None and default is not None + help += " (default: %(default)s)" super().__init__( option_strings=_option_strings, @@ -63,8 +63,8 @@ def __call__( "BooleanOptionalAction can't be a positional argument. " f"Something is wrong with {self.option_strings[0]}" ) - if option_string in self.option_strings: - setattr(namespace, self.dest, not option_string.startswith("--no-")) + assert option_string in self.option_strings + setattr(namespace, self.dest, not option_string.startswith("--no-")) def format_usage(self) -> str: """Return usage string."""