From d25159e05d3e94c79068fc418d574bceab593887 Mon Sep 17 00:00:00 2001 From: FalloutFalcon Date: Wed, 25 Feb 2026 15:19:46 -0600 Subject: [PATCH 1/3] swpas factions to be on clan proper, and some fixes --- .../modules/powers/code/discipline/necromancy.dm | 3 +-- .../code/discipline/obtenebration}/creatures.dm | 2 ++ .../code/discipline/{ => obtenebration}/obtenebration.dm | 0 .../powers/code/discipline/thaumaturgy/path_of_blood.dm | 2 +- .../powers/code/discipline/vicissitude/vicissitude.dm | 2 +- .../code/vampire_clan/__vampire_clan.dm | 5 +++++ .../code/vampire_clan/clans/baali/baali.dm | 3 --- .../code/vampire_clan/clans/lasombra/lasombra.dm | 2 +- .../code/vampire_clan/clans/tzimisce/creatures.dm | 1 + tgstation.dme | 4 ++-- 10 files changed, 14 insertions(+), 10 deletions(-) rename modular_darkpack/modules/{vampire_the_masquerade/code/vampire_clan/clans/lasombra => powers/code/discipline/obtenebration}/creatures.dm (86%) rename modular_darkpack/modules/powers/code/discipline/{ => obtenebration}/obtenebration.dm (100%) diff --git a/modular_darkpack/modules/powers/code/discipline/necromancy.dm b/modular_darkpack/modules/powers/code/discipline/necromancy.dm index 6001934b793f..65a305016b65 100644 --- a/modular_darkpack/modules/powers/code/discipline/necromancy.dm +++ b/modular_darkpack/modules/powers/code/discipline/necromancy.dm @@ -9,8 +9,7 @@ /datum/discipline/necromancy/post_gain() . = ..() - - owner.add_faction(VAMPIRE_CLAN_GIOVANNI) + // owner.add_faction(VAMPIRE_CLAN_GIOVANNI) var/datum/action/ritual_drawing/necromancy/ritualist = new() ADD_TRAIT(owner, TRAIT_NECROMANCY_KNOWLEDGE, DISCIPLINE_TRAIT) ritualist.Grant(owner) diff --git a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/creatures.dm b/modular_darkpack/modules/powers/code/discipline/obtenebration/creatures.dm similarity index 86% rename from modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/creatures.dm rename to modular_darkpack/modules/powers/code/discipline/obtenebration/creatures.dm index d03a82a7e2ff..2823dd3912b8 100644 --- a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/creatures.dm +++ b/modular_darkpack/modules/powers/code/discipline/obtenebration/creatures.dm @@ -1,3 +1,4 @@ +// Dubiously deprecated as i think we replaced them with /mob/living/basic/shadow_guard /mob/living/basic/lasombra name = "shadow abomination" desc = "A ferocious, fang-bearing creature that resembles a spider." @@ -23,6 +24,7 @@ bloodpool = 0 maxbloodpool = 0 bloodquality = BLOOD_QUALITY_LOW + ai_controller = /datum/ai_controller/basic_controller/simple/simple_hostile /mob/living/basic/lasombra/better icon_state = "shadow2" diff --git a/modular_darkpack/modules/powers/code/discipline/obtenebration.dm b/modular_darkpack/modules/powers/code/discipline/obtenebration/obtenebration.dm similarity index 100% rename from modular_darkpack/modules/powers/code/discipline/obtenebration.dm rename to modular_darkpack/modules/powers/code/discipline/obtenebration/obtenebration.dm diff --git a/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm b/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm index 207df790feff..00355363eafc 100644 --- a/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm +++ b/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm @@ -7,7 +7,7 @@ /datum/discipline/thaumaturgy/post_gain() . = ..() - owner.add_faction(VAMPIRE_CLAN_TREMERE) + // owner.add_faction(VAMPIRE_CLAN_TREMERE) var/datum/action/ritual_drawing/thaumaturgy/thaumaturgy = new() thaumaturgy.Grant(owner) thaumaturgy.level = level diff --git a/modular_darkpack/modules/powers/code/discipline/vicissitude/vicissitude.dm b/modular_darkpack/modules/powers/code/discipline/vicissitude/vicissitude.dm index 6054c713b9a6..4127c0103edc 100644 --- a/modular_darkpack/modules/powers/code/discipline/vicissitude/vicissitude.dm +++ b/modular_darkpack/modules/powers/code/discipline/vicissitude/vicissitude.dm @@ -7,7 +7,7 @@ /datum/discipline/vicissitude/post_gain() . = ..() - owner.faction |= VAMPIRE_CLAN_TZIMISCE + // owner.add_faction(VAMPIRE_CLAN_TZIMISCE) ADD_TRAIT(owner, TRAIT_VICISSITUDE_KNOWLEDGE, DISCIPLINE_TRAIT) /datum/discipline_power/vicissitude diff --git a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/__vampire_clan.dm b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/__vampire_clan.dm index f003e59fc87a..a401e8812610 100644 --- a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/__vampire_clan.dm +++ b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/__vampire_clan.dm @@ -83,6 +83,9 @@ if(ispath(discipline, /datum/discipline)) vampire.give_st_power(discipline, 5) + // Mostly for summons to not kill you. + vampire.add_faction(id) + /** * Undoes the effects of on_gain to more or less * remove the effects of gaining the Clan. By default, @@ -111,6 +114,8 @@ vampire.remove_overlay(equipped_accessory) */ + vampire.remove_faction(id) + /** * Applies Clan-specific effects when the * mob that has the Clan logs into their mob diff --git a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/baali/baali.dm b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/baali/baali.dm index 254e75e1a62f..873e15d1cb43 100644 --- a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/baali/baali.dm +++ b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/baali/baali.dm @@ -22,9 +22,6 @@ /datum/subsplat/vampire_clan/baali/on_gain(mob/living/carbon/human/H) . = ..() - - H.add_faction(VAMPIRE_CLAN_BAALI) - H.AddElement(/datum/element/holy_weakness) H.gain_trauma(new /datum/brain_trauma/mild/phobia/religion, TRAUMA_RESILIENCE_ABSOLUTE) diff --git a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm index 0b4de0e48d55..91a05ef86b24 100644 --- a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm +++ b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm @@ -21,8 +21,8 @@ /datum/subsplat/vampire_clan/lasombra/on_gain(mob/living/carbon/human/H) . = ..() + //... Im like pretty sure this is depricated by TRAIT_NO_MIRROR_REFLECTION and causes them to not show up looking down at other z levels. Strongly consider removing this. H.vis_flags |= VIS_HIDE - H.add_faction(VAMPIRE_CLAN_LASOMBRA) // Not TTRPG accurate and is pending a rework to use real rolls after #633 /proc/scramble_lasombra_message(message, mob/living/lasombra) diff --git a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/tzimisce/creatures.dm b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/tzimisce/creatures.dm index 7e2f2193cde1..d9559c9f0368 100644 --- a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/tzimisce/creatures.dm +++ b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/tzimisce/creatures.dm @@ -26,6 +26,7 @@ bloodquality = BLOOD_QUALITY_LOW bloodpool = 2 maxbloodpool = 2 + ai_controller = /datum/ai_controller/basic_controller/simple/simple_hostile_obstacles /mob/living/basic/szlachta/fister name = "fister" diff --git a/tgstation.dme b/tgstation.dme index 718b13fd362a..49436fea1ae7 100644 --- a/tgstation.dme +++ b/tgstation.dme @@ -7398,7 +7398,6 @@ #include "modular_darkpack\modules\powers\code\discipline\animalism.dm" #include "modular_darkpack\modules\powers\code\discipline\dementation.dm" #include "modular_darkpack\modules\powers\code\discipline\necromancy.dm" -#include "modular_darkpack\modules\powers\code\discipline\obtenebration.dm" #include "modular_darkpack\modules\powers\code\discipline\serpentis.dm" #include "modular_darkpack\modules\powers\code\discipline\torpor.dm" #include "modular_darkpack\modules\powers\code\discipline\auspex\aura_component.dm" @@ -7422,6 +7421,8 @@ #include "modular_darkpack\modules\powers\code\discipline\fortitude\fortitude_status_effect.dm" #include "modular_darkpack\modules\powers\code\discipline\obfuscate\obfuscate.dm" #include "modular_darkpack\modules\powers\code\discipline\obfuscate\obfuscate_helpers.dm" +#include "modular_darkpack\modules\powers\code\discipline\obtenebration\creatures.dm" +#include "modular_darkpack\modules\powers\code\discipline\obtenebration\obtenebration.dm" #include "modular_darkpack\modules\powers\code\discipline\potence\potence.dm" #include "modular_darkpack\modules\powers\code\discipline\potence\potence_status_effect.dm" #include "modular_darkpack\modules\powers\code\discipline\presence\presence.dm" @@ -7619,7 +7620,6 @@ #include "modular_darkpack\modules\vampire_the_masquerade\code\vampire_clan\clans\baali\baali.dm" #include "modular_darkpack\modules\vampire_the_masquerade\code\vampire_clan\clans\baali\holy_weakness.dm" #include "modular_darkpack\modules\vampire_the_masquerade\code\vampire_clan\clans\kiasyd\kiasyd.dm" -#include "modular_darkpack\modules\vampire_the_masquerade\code\vampire_clan\clans\lasombra\creatures.dm" #include "modular_darkpack\modules\vampire_the_masquerade\code\vampire_clan\clans\lasombra\lasombra.dm" #include "modular_darkpack\modules\vampire_the_masquerade\code\vampire_clan\clans\malkavian\malkavian.dm" #include "modular_darkpack\modules\vampire_the_masquerade\code\vampire_clan\clans\tzimisce\crafting_recipes.dm" From bfb662dfb68f8a568bea28489195b1074639d360 Mon Sep 17 00:00:00 2001 From: FalloutFalcon Date: Wed, 25 Feb 2026 15:46:20 -0600 Subject: [PATCH 2/3] yea --- .../powers/code/discipline/obtenebration/obtenebration.dm | 4 ++-- .../code/vampire_clan/clans/lasombra/lasombra.dm | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/modular_darkpack/modules/powers/code/discipline/obtenebration/obtenebration.dm b/modular_darkpack/modules/powers/code/discipline/obtenebration/obtenebration.dm index 30572b4a214f..938c4633668c 100644 --- a/modular_darkpack/modules/powers/code/discipline/obtenebration/obtenebration.dm +++ b/modular_darkpack/modules/powers/code/discipline/obtenebration/obtenebration.dm @@ -114,7 +114,7 @@ var/list/active_tentacles = list() -/datum/discipline_power/obtenebration/arms_of_the_abyss/activate(var/atom/target) +/datum/discipline_power/obtenebration/arms_of_the_abyss/activate(atom/target) . = ..() var/turf/target_turf = get_turf(target) var/dice = (owner.st_get_stat(STAT_MANIPULATION) + owner.st_get_stat(STAT_OCCULT)) @@ -345,7 +345,7 @@ var/datum/discipline_power/obtenebration/arms_of_the_abyss/abyss_power = vampire?.get_discipline_power(/datum/discipline_power/obtenebration/arms_of_the_abyss) var/tentacles = 0 - for(var/mob/living/basic/abyss_tentacle/T in abyss_power.active_tentacles) + for(var/mob/living/basic/abyss_tentacle/T in abyss_power?.active_tentacles) if(T && !QDELETED(T)) var/was_passive = (T.aggro_mode == "Passive") T.aggro_mode = select diff --git a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm index 91a05ef86b24..9885adcd9808 100644 --- a/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm +++ b/modular_darkpack/modules/vampire_the_masquerade/code/vampire_clan/clans/lasombra/lasombra.dm @@ -18,12 +18,6 @@ enlightenment = TRUE clan_keys = /obj/item/vamp/keys/lasombra -/datum/subsplat/vampire_clan/lasombra/on_gain(mob/living/carbon/human/H) - . = ..() - - //... Im like pretty sure this is depricated by TRAIT_NO_MIRROR_REFLECTION and causes them to not show up looking down at other z levels. Strongly consider removing this. - H.vis_flags |= VIS_HIDE - // Not TTRPG accurate and is pending a rework to use real rolls after #633 /proc/scramble_lasombra_message(message, mob/living/lasombra) var/static/list/zalgo_letters = list( From 7ba535cbc1884cebff6b04db0bdd14be0d8b6a74 Mon Sep 17 00:00:00 2001 From: FalloutFalcon Date: Wed, 25 Feb 2026 21:54:02 -0600 Subject: [PATCH 3/3] review --- modular_darkpack/modules/powers/code/discipline/necromancy.dm | 1 - .../modules/powers/code/discipline/thaumaturgy/path_of_blood.dm | 1 - 2 files changed, 2 deletions(-) diff --git a/modular_darkpack/modules/powers/code/discipline/necromancy.dm b/modular_darkpack/modules/powers/code/discipline/necromancy.dm index 96ddfaf8eff3..88a8bc05bbc1 100644 --- a/modular_darkpack/modules/powers/code/discipline/necromancy.dm +++ b/modular_darkpack/modules/powers/code/discipline/necromancy.dm @@ -9,7 +9,6 @@ /datum/discipline/necromancy/post_gain() . = ..() - // owner.add_faction(VAMPIRE_CLAN_GIOVANNI) var/datum/action/ritual_drawing/necromancy/ritualist = new() ritualist.Grant(owner) ritualist.level = level diff --git a/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm b/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm index 5bd8cde9150a..1a13712c2eba 100644 --- a/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm +++ b/modular_darkpack/modules/powers/code/discipline/thaumaturgy/path_of_blood.dm @@ -7,7 +7,6 @@ /datum/discipline/thaumaturgy/post_gain() . = ..() - // owner.add_faction(VAMPIRE_CLAN_TREMERE) var/datum/action/ritual_drawing/thaumaturgy/thaumaturgy = new() thaumaturgy.Grant(owner) thaumaturgy.level = level