Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null values in PFBs #2462

Closed
jessebrennan opened this issue Nov 17, 2020 · 3 comments
Closed

Allow null values in PFBs #2462

jessebrennan opened this issue Nov 17, 2020 · 3 comments
Assignees
@nadove-ucsc
Labels
+ [priority] High debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team enh [type] New feature or request manifests [subject] Generation and contents of manifests orange [process] Done by the Azul team

Comments

@jessebrennan
Copy link
Contributor

jessebrennan commented Nov 17, 2020 •
edited by hannes-ucsc
Loading

Remove the work around for #2370 when https://broadworkbench.atlassian.net/browse/AS-521 is fixed.
@jessebrennan jessebrennan added code [subject] Production code orange [process] Done by the Azul team labels Nov 17, 2020
@jessebrennan jessebrennan self-assigned this Nov 17, 2020
@melainalegaspi melainalegaspi added the debt [type] A defect incurring continued engineering cost label Nov 17, 2020
@hannes-ucsc hannes-ucsc added the enh [type] New feature or request label Nov 5, 2021
@theathorn theathorn added manifests [subject] Generation and contents of manifests and removed code [subject] Production code labels Nov 5, 2021
@hannes-ucsc
Copy link
Member

Looks like https://broadworkbench.atlassian.net/browse/AS-521 is fixed so we can move forward with this.

@hannes-ucsc
Copy link
Member

I want to solve this, and thereby verify the upstream resolution, before we get deeper into the verbatim hand-over epic (#2693). In fact, I will add this to that epic.

@achave11-ucsc achave11-ucsc added the + [priority] High label Aug 1, 2023
nadove-ucsc added a commit that referenced this issue Aug 1, 2023
@nadove-ucsc
Allow null values in PFBs (#2462)
e958f9a
@nadove-ucsc nadove-ucsc mentioned this issue Aug 1, 2023
Merged
99 tasks
nadove-ucsc added a commit that referenced this issue Aug 2, 2023
@nadove-ucsc
Allow null values in PFBs (#2462)
a01d54e
nadove-ucsc added a commit that referenced this issue Aug 3, 2023
@nadove-ucsc
Allow null values in PFBs (#2462)
72fe0f5
@nadove-ucsc
Copy link
Contributor

For demo, create and download a reasonably small PFB manifest using the Swagger UI. Confirm the presence of null values using pfb show. Then perform a handover to Terra via the Data Browser using the same set of filters. Confirm presence of null values in the workspace.

@nadove-ucsc nadove-ucsc added the demo [process] To be demonstrated at the end of the sprint label Aug 3, 2023
achave11-ucsc pushed a commit that referenced this issue Aug 7, 2023
@nadove-ucsc @achave11-ucsc
Allow null values in PFBs (#2462)
0f4b45f
achave11-ucsc added a commit that referenced this issue Aug 8, 2023
@achave11-ucsc
Allow null values in PFBs (#2462, PR #5444)
4c2f0de
@nadove-ucsc nadove-ucsc mentioned this issue Aug 18, 2023
Closed
14 tasks
@dsotirho-ucsc dsotirho-ucsc added the demoed [process] Successfully demonstrated to team label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadove-ucsc nadove-ucsc

Labels
+ [priority] High debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team enh [type] New feature or request manifests [subject] Generation and contents of manifests orange [process] Done by the Azul team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@hannes-ucsc @jessebrennan @achave11-ucsc @theathorn @melainalegaspi @dsotirho-ucsc @nadove-ucsc