Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact manifest rows for related files have main file's DRS URI #2846

Closed
achave11-ucsc opened this issue Mar 2, 2021 · 4 comments
Closed

Compact manifest rows for related files have main file's DRS URI #2846

achave11-ucsc opened this issue Mar 2, 2021 · 4 comments
Assignees
@achave11-ucsc
Labels
bug [type] A defect preventing use of the system as specified code [subject] Production code demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team

Comments

@achave11-ucsc
Copy link
Member

No description provided.

@achave11-ucsc achave11-ucsc added the orange [process] Done by the Azul team label Mar 2, 2021
@achave11-ucsc achave11-ucsc self-assigned this Mar 2, 2021
@achave11-ucsc
Copy link
Member Author

#2841 (comment)

@melainalegaspi melainalegaspi changed the title Compact manifest provision invalid zarr related files Compact manifest provisions invalid zarr related files Mar 2, 2021
@hannes-ucsc hannes-ucsc changed the title Compact manifest provisions invalid zarr related files In compact manifests, file_drs_path column of related files points at main file Mar 2, 2021
@hannes-ucsc hannes-ucsc changed the title In compact manifests, file_drs_path column of related files points at main file In compact manifests, file_drs_path column of related files points at main file Mar 2, 2021
@hannes-ucsc
Copy link
Member

The assignment to @jessebrennan was consistent with my instructions on PR #2841. The test added by Jesse did not detect this issue but it could and should have.

However, the test was since then improved by @achave11 (just not enough to reproduce this issue) and he is more deeply involved in this now, so I'll be assigning it to him.

@hannes-ucsc hannes-ucsc added code [subject] Production code bug [type] A defect preventing use of the system as specified labels Mar 2, 2021
@hannes-ucsc
Copy link
Member

#2538 was reopened because of a similar issue with related files in curl manifests. It needs to be fully addressed before we can attempt to address this one.

@hannes-ucsc hannes-ucsc changed the title In compact manifests, file_drs_path column of related files points at main file Compact manifest rows for related files point to DRS path of main file Mar 11, 2021
@hannes-ucsc hannes-ucsc changed the title Compact manifest rows for related files point to DRS path of main file Compact manifest rows for related files contain DRS path of main file Mar 11, 2021
@hannes-ucsc hannes-ucsc changed the title Compact manifest rows for related files contain DRS path of main file Compact manifest rows for related files point to main file's DRS URI Mar 11, 2021
@hannes-ucsc hannes-ucsc changed the title Compact manifest rows for related files point to main file's DRS URI Compact manifest rows for related files have main file's DRS URI Mar 11, 2021
achave11-ucsc added a commit that referenced this issue Apr 23, 2021
@achave11-ucsc
[r] Fix: Compact manifest rows for related files have main file's DRS…
aa977e7 
… URI (#2846)
achave11-ucsc added a commit that referenced this issue Apr 23, 2021
@achave11-ucsc
[r] Fix: Compact manifest rows for related files have main file's DRS…
28e48bb 
… URI (#2846, PR #2847)
@achave11-ucsc
Copy link
Member Author

achave11-ucsc commented Apr 23, 2021 •
edited
Loading

Unit test failed prod deployment in Gitlab.

dsotirho-ucsc pushed a commit that referenced this issue May 4, 2021
@achave11-ucsc @dsotirho-ucsc
Fix: Test fails if AZUL_DRS_DOMAIN_NAME is not defined (#2846)
1b6f163
dsotirho-ucsc added a commit that referenced this issue May 4, 2021
@dsotirho-ucsc
Fix: Test fails if AZUL_DRS_DOMAIN_NAME is not defined (#2846, PR #3012)
574c067
@melainalegaspi melainalegaspi added the demoed [process] Successfully demonstrated to team label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achave11-ucsc achave11-ucsc

Labels
bug [type] A defect preventing use of the system as specified code [subject] Production code demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hannes-ucsc @jessebrennan @achave11-ucsc @melainalegaspi