Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a list of the possible fields included in the compact and full manifests #3074

Closed
NoopDog opened this issue May 24, 2021 · 2 comments
Labels
orange [process] Done by the Azul team

Comments

@NoopDog
Copy link
Contributor

NoopDog commented May 24, 2021

We will be documenting what is in the manifests on the data portal and will need information on what they will contain in the full case.

One approach is to just download a manifest of each type and look at the headers and this may be fine.

However, I wanted to check if there was the possibility that some fields in the downloaded manifest might be missing for a given project as the project does not use that field.

Can you advise on the best way to obtain the set of fields in each manifest or provide the list?

Thank you,

@github-actions github-actions bot added the orange [process] Done by the Azul team label May 24, 2021
@theathorn theathorn changed the title Provide a list of the possible fields included in the fields compact and full manifests Provide a list of the possible fields included in the compact and full manifests May 25, 2021
@hannes-ucsc
Copy link
Member

hannes-ucsc commented May 25, 2021

We should stop promoting the full manifest because of its many flaws. In the mid-term, it will be replaced by a JSON manifest (#2693). In the short-term the "download metadata" link on the projects page will be changed to point to the compact manifest instead (DataBiosphere/data-browser#1766).

Since the manifests are an artifact produced by Azul, the correct place to document them is not on the Data Portal but as part of Azul's OpenAPI specification. Otherwise we'd create a brittle coupling between the Azul implementation and the Portal documentation. Instead, the portal could contain links that point to Azul's Swagger UI, or even have an (semi)-automated process that imports the manifest documentation from Azul's OpenAPI specification. I doubt it's a good idea to invest my team's time in a one-off effort that's leaves the AvroPFB and BDBag formats undocumented and that's bound to become stale in matters of months.

If you want to help extend the documentation of Azul's manifest APIs as part of its OpenAPI spec, we can discuss ways for you to contribute to the Azul source code.

A list of compact manifest fields will be created by #3072.

@theathorn
Copy link

theathorn commented May 25, 2021

dup of #3055.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

3 participants