Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PFB manifests include properties absent in aggregates #3408

Closed
amarjandu opened this issue Sep 7, 2021 · 1 comment
Closed

PFB manifests include properties absent in aggregates #3408

amarjandu opened this issue Sep 7, 2021 · 1 comment
Labels
bug [type] A defect preventing use of the system as specified debt [type] A defect incurring continued engineering cost manifests [subject] Generation and contents of manifests orange [process] Done by the Azul team

Comments

@amarjandu
Copy link
Contributor

For example, publications within a project PFB entity are always set to an empty list. This is because _project_types declares that property but the corresponding aggregator suppresses it. It would be better if _project_types declared whether a property is absent from aggregates. That way, the PFB generator wouldn't need to emit a dummy value for these types of properties.
@amarjandu amarjandu added the orange [process] Done by the Azul team label Sep 7, 2021
@melainalegaspi melainalegaspi added code [subject] Production code debt [type] A defect incurring continued engineering cost labels Sep 8, 2021
@melainalegaspi melainalegaspi added the bug [type] A defect preventing use of the system as specified label Sep 30, 2021
@theathorn theathorn added manifests [subject] Generation and contents of manifests and removed code [subject] Production code labels Nov 5, 2021
@bvizzier-ucsc
Copy link

@hannes-ucsc: "Made obsolete by #2693."

@bvizzier-ucsc bvizzier-ucsc closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [type] A defect preventing use of the system as specified debt [type] A defect incurring continued engineering cost manifests [subject] Generation and contents of manifests orange [process] Done by the Azul team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@amarjandu @jessebrennan @bvizzier-ucsc @theathorn @melainalegaspi @dsotirho-ucsc