Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXMEs reference closed external issues #6596

Open
nadove-ucsc opened this issue Sep 25, 2024 · 4 comments
Open

FIXMEs reference closed external issues #6596

nadove-ucsc opened this issue Sep 25, 2024 · 4 comments
Assignees
Labels
orange [process] Done by the Azul team spike:1 [process] Spike estimate of one point

Comments

@nadove-ucsc
Copy link
Contributor

# FIXME: Remove condition once https://github.com/HumanCellAtlas/metadata-schema/issues/623 is resolved

The linked issue has been closed. This may manifest as a bug where zarr files are missing from replicas' lists of hub IDs and from the inner entity arrays of cell suspensions and samples.

@nadove-ucsc nadove-ucsc added the orange [process] Done by the Azul team label Sep 25, 2024
@dsotirho-ucsc dsotirho-ucsc added the spike:1 [process] Spike estimate of one point label Sep 25, 2024
@dsotirho-ucsc
Copy link
Contributor

Spike to investigate.

@nadove-ucsc
Copy link
Contributor Author

There is a related FIXME that references another closed ticket:

# FIXME: Remove condition once https://github.com/HumanCellAtlas/metadata-schema/issues/579 is resolved

@nadove-ucsc nadove-ucsc changed the title FIXME references closed issue FIXMEs reference closed external issues Sep 27, 2024
@nadove-ucsc
Copy link
Contributor Author

I couldn't find any evidence of what the symptoms might be because I couldn't find any zarray files in the index.

@nadove-ucsc nadove-ucsc removed their assignment Sep 27, 2024
@nadove-ucsc
Copy link
Contributor Author

@hannes-ucsc: "The solution is to remove the FIXMEs. While the blocking issue was resolved, there are no more zarrays in DCP2 and I don't want to touch the code that supports them."

@nadove-ucsc nadove-ucsc self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange [process] Done by the Azul team spike:1 [process] Spike estimate of one point
Projects
None yet
Development

No branches or pull requests

2 participants