Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WDL sibling file imports work even when they come from converting Strings to Files #4688

Open
adamnovak opened this issue Nov 16, 2023 · 1 comment
Labels

Comments

@adamnovak
Copy link
Member

adamnovak commented Nov 16, 2023

Right now we use some local-to-the-job logic for assigning UUIDs to directories to ensure that sibling files in WDL stay siblings when downloaded elsewhere.

But when converting Strings to Files, two sibling files can be uploaded in different jobs, which means they will get different UUIDs and will not be downloaded as siblings.

We should fix it so they are downloaded as siblings.

We probably don't have to handle the case where the filesystem on the leader changes while a workflow is running, in a way that would matter; we can leave that as undefined behavior.

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1449

@adamnovak adamnovak added the wdl label Nov 16, 2023
@adamnovak
Copy link
Member Author

This is related to #5004 which goes the other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant