Code coverage tooling #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
changed the title
TonyCTHsu
approved these changes
Aug 31, 2023
| @@ -20,6 +20,9 @@ gem "standard", "~> 1.31.0" | |||
| gem "yard" | |||
| gem "webrick" | |||
|
|
|||
| gem "simplecov" | |||
There was a problem hiding this comment.
Great! Do need to use our fork for simplecov. 👍
There was a problem hiding this comment.
Instead of using our fork I disabled jruby coverage reporting as jruby support is questionable for this gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds code coverage support with simplecov and CodeCov.
Motivation
Creating necessary development tooling before releasing the gem
Additional Notes
Note: upload to Codecov currently fails with
Did anyone encounter this? I suspect that the reason behind it is that the repository not public; will try to run it again as soon as we make it public.
How to test the change?
Tested via CircleCI