prepare gemspec for release; specify ddtrace as dev dependency, not runtime one #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
force-pushed
the
anmarchenko/gemspec_refinement
branch
from
324d396
to
f0b4e91
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
TonyCTHsu
approved these changes
Sep 11, 2023
| spec.metadata["homepage_uri"] = spec.homepage | ||
| spec.metadata["source_code_uri"] = "https://github.com/DataDog/datadog-ci-rb" | ||
|
|
||
| spec.files = |
There was a problem hiding this comment.
Can add a test similar to https://github.com/DataDog/dd-trace-rb/blob/master/spec/ddtrace/release_gem_spec.rb ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds more details to gemspec preparing for the future v0.1 release.
Removes runtime dependency on ddtrace as part of "migration phase 1".
Motivation
Needing to clean up before release.
How to test the change?
Do these changes make sense?