Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-60] Report total lines coverage percentage to Datadog #240

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Sep 24, 2024

What does this PR do?
Adds support for total code coverage reporting feature.

Supported code coverage library: gem "simplecov" >= 0.18.0

Motivation
Achieving feature parity across Datadog libraries

How to test the change?

Tested using rubocop project:
image

... and middleman:
image

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 89.89899% with 10 lines in your changes missing coverage. Please review.

Project coverage is 98.89%. Comparing base (17b2e4f) to head (9b12d3d).

Files with missing lines Patch % Lines
lib/datadog/ci/test_visibility/total_coverage.rb 60.00% 8 Missing ⚠️
...b/datadog/ci/contrib/simplecov/result_extractor.rb 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   98.95%   98.89%   -0.07%     
==========================================
  Files         273      279       +6     
  Lines       13425    13524      +99     
  Branches      609      620      +11     
==========================================
+ Hits        13285    13374      +89     
- Misses        140      150      +10     
Flag Coverage Δ
98.89% <89.89%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko changed the title [SDTEST-60] Report total coverage percentage to Datadog [SDTEST-60] Report total lines coverage percentage to Datadog Sep 24, 2024
@anmarchenko anmarchenko marked this pull request as ready for review September 24, 2024 13:27
@anmarchenko anmarchenko requested review from a team as code owners September 24, 2024 13:27
@anmarchenko anmarchenko added this to the 1.7.0 milestone Sep 25, 2024
@anmarchenko anmarchenko merged commit a997734 into main Sep 25, 2024
30 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/total_code_coverage_reporting branch September 25, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants