Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent SpanIDs and TraceIDs in span links #154

Open
mabdinur opened this issue Dec 8, 2023 · 0 comments
Open

Inconsistent SpanIDs and TraceIDs in span links #154

mabdinur opened this issue Dec 8, 2023 · 0 comments
Assignees

Comments

@mabdinur
Copy link

mabdinur commented Dec 8, 2023

Test agent produces snapshot files with normalized span_ids and trace_ids. However this normalization is not applied to span ids and trace ids in span_links. This hinders the reproducibility of snapshot tests (test runs that generate different span ids will generate different snapshots).

A simple fix would be to add span_links and meta._dd.spans_links to DEFAULT_SNAPSHOT_IGNORES. However it would be nice to actually validate span_link values in snapshot tests.

There are two scenarios we need to handle:

  • All span links reference spans that are received by the test agent (here we can neatly normalize all ids)
  • Some span links reference span/trace ids that are NOT received by the test agent. This scenario is a bit tricky. The best we could potentially do here is set some "catch_all" value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants