Skip to content

Commit 549d34e

Browse files
authored
Merge pull request #974 from DataDog/sbarrio/internal/fix-typos-on-md-files
Fix typos on several .md files
2 parents 84b4b04 + ff50785 commit 549d34e

File tree

3 files changed

+36
-22
lines changed

3 files changed

+36
-22
lines changed

TROUBLESHOOTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ See the [dedicated troubleshooting guide](./docs/troubleshooting_no_data.md).
99
Original issue: https://github.com/DataDog/dd-sdk-reactnative/issues/41
1010

1111
If you have the following error message:
12+
1213
```
1314
Undefined symbols for architecture x86_64:
1415
"static Foundation.JSONEncoder.OutputFormatting.withoutEscapingSlashes.getter : Foundation.JSONEncoder.OutputFormatting", referenced from:
@@ -17,6 +18,7 @@ Undefined symbols for architecture x86_64:
1718
```
1819

1920
open Xcode and go to `Build Settings` of your project (_not your app target_) then make sure `Library Search Paths` is the following:
21+
2022
```
2123
LIBRARY_SEARCH_PATHS = (
2224
"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",
@@ -42,7 +44,7 @@ We made the change below to fix it:
4244
### Infinite loop-like error messages
4345

4446
Sometimes, almost randomly, my RN project gives error messages non-stop.
45-
CPU usage goes up to %+100 and you'll quickly notice a problem with your laptop fan goes crazy.
47+
CPU usage goes up to 100%+ and you'll quickly notice a problem when your laptop fan goes crazy.
4648

4749
This is the issue: https://github.com/facebook/react-native/issues/28801
4850

benchmarks/README.md

Lines changed: 31 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
2. From the iOS folder, run `pod install`.
77
3. From the root folder, run `yarn ios` or `yarn android`.
88

9-
## Enable new architcture
9+
## Enable new architecture
1010

1111
### iOS
1212

@@ -20,7 +20,7 @@ Set `newArchEnabled=true` in `benchmarks/android/gradle.properties`.
2020

2121
## ENV config
2222

23-
The `.env` config file contains configuration for the Datadog API, as well as a test scenario that you can launch when the app boots up. If it doesn't contain a test scenario, the app waits for a deeplink to trigger a test scenario instead.
23+
The `.env` config file contains a configuration for the Datadog API, as well as a test scenario that you can launch when the app boots up. If it doesn't contain a test scenario, the app waits for a deep link to trigger a test scenario instead.
2424

2525
DD_CLIENT_TOKEN="CLIENT_TOKEN"
2626
DD_API_KEY="API_KEY"
@@ -33,37 +33,43 @@ The `.env` config file contains configuration for the Datadog API, as well as a
3333
## Changing ENV settings
3434

3535
### Debug
36+
3637
```
3738
$ ENVFILE=.env.alternate yarn ios
3839
```
40+
3941
or:
4042

4143
```
4244
$ ENVFILE=.env.alternate yarn android
4345
```
4446

4547
### Release
48+
4649
On Android:
47-
```
50+
51+
```
4852
$ ENVFILE=.env.alternate ./gradlew assembleRelease
4953
```
50-
54+
5155
On iOS:
52-
```
56+
57+
```
5358
xcodebuild -scheme alternate
54-
```
59+
```
5560

56-
## Set test scenarios using deeplinks
61+
## Set test scenarios using deep links
5762

58-
You can trigger test scenarios by running a deeplink with a specific set of parameters to the benchmark app.
63+
You can trigger test scenarios by running a deep link with a specific set of parameters to the benchmark app.
5964

6065
## Run a test scenario
6166

6267
Launch a specific test scenario with a particular configuration:
68+
6369
- **Method**: `start`
6470
- **Parameters**:
65-
- **scenario**: name of the test as defined on `Scenario` enum in `types/testConfig.ts`
66-
- **runType**: `instrumented|baseline|profiling`
71+
- **scenario**: name of the test as defined on the `Scenario` enum in `types/testConfig.ts`
72+
- **runType**: `instrumented|baseline|profiling`
6773

6874
### iOS
6975

@@ -95,9 +101,9 @@ xcrun simctl openurl booted "benchmark://stop"
95101
adb shell am start -W -a android.intent.action.VIEW -d 'benchmark://stop' com.benchmarkrunner
96102
```
97103

98-
## Adding a New Scenario to Benchmarks
104+
## Adding a new scenario to benchmarks
99105

100-
### Define the New Scenario
106+
### Define the new scenario
101107

102108
In `benchmarks/src/testSetup/types/testConfig.ts`, add a new entry to the `Scenario` enum:
103109

@@ -110,22 +116,22 @@ export enum Scenario {
110116
}
111117
```
112118

113-
The string value (`'newScenario'`) is what must be passed using deeplink as the `scenario` parameter.
119+
The string value (`'newScenario'`) is what must be passed using a deep link as the `scenario` parameter.
114120

115121
Alternatively, if you're using a `.env` file to set the scenario, add:
116122

117123
```env
118124
BENCH_SCENARIO="newScenario"
119125
```
120126

121-
### Create the Scenario Component
127+
### Create the scenario component
122128

123129
Create a new folder under `benchmarks/src/scenario/` named after your scenario (for example, `NewScenario`). Inside this folder, define your scenario’s main component and its props.
124130

125131
Create a `types.ts` file:
126132

127133
```ts
128-
import type { TestConfig } from "benchmarks/src/testSetup/types/testConfig";
134+
import type {TestConfig} from 'benchmarks/src/testSetup/types/testConfig';
129135

130136
export type NewScenarioProps = {
131137
testConfig?: TestConfig;
@@ -144,7 +150,7 @@ function NewScenario(props: NewScenarioProps): React.JSX.Element {
144150
export default NewScenario;
145151
```
146152

147-
### Register the Scenario in the App
153+
### Register the scenario in the app
148154

149155
In `benchmarks/src/App.tsx`, add a new case to the scenario switch using the enum identifier you just created:
150156

@@ -153,9 +159,9 @@ case Scenario.NewScenario:
153159
return <NewScenario testConfig={testConfig} />;
154160
```
155161

156-
You can now trigger this scenario either through a deeplink or by setting `BENCH_SCENARIO` in the `.env` file.
162+
You can then trigger this scenario through either a deep link or by setting `BENCH_SCENARIO` in the `.env` file.
157163

158-
## Instrumenting a Scenario
164+
## Instrument a scenario
159165

160166
Depending on the scenario’s structure and flow, the Datadog SDK initialization may vary. Each scenario is responsible for managing its own initialization logic.
161167

@@ -178,5 +184,11 @@ useEffect(() => {
178184
If your scenario uses the `DatadogProvider`, you can retrieve the necessary configuration using `getDatadogProviderConfig()` from the same `testUtils` module:
179185

180186
```ts
181-
return <DatadogProvider config={getDatadogProviderConfig()} onInitialization={onDatadogInitialization}>...</DatadogProvider>
187+
return (
188+
<DatadogProvider
189+
config={getDatadogProviderConfig()}
190+
onInitialization={onDatadogInitialization}>
191+
...
192+
</DatadogProvider>
193+
);
182194
```

packages/core/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const datadogConfiguration = new DatadogProviderConfiguration(
4646
true, // track XHR Resources
4747
true // track Errors
4848
);
49-
// Optional: Select your Datadog website (one of "US1", "US3", "US5", EU1", "AP1", "AP2", or "US1_FED"). Default is "US1".
49+
// Optional: Select your Datadog website (one of "US1", "US3", "US5", "EU1", "AP1", "AP2", or "US1_FED"). Default is "US1".
5050
datadogConfiguration.site = 'US1';
5151
// Optional: enable or disable native crash reports
5252
datadogConfiguration.nativeCrashReportEnabled = true;
@@ -102,7 +102,7 @@ tempers with the linux kernel, the stored data might become readable.
102102
### iOS
103103

104104
Before data is uploaded to Datadog, it is stored in cleartext in the cache directory (`Library/Caches`)
105-
of your [application sandbox](4), which can't be read by any other app installed on the device.
105+
of your [application sandbox][4], which can't be read by any other app installed on the device.
106106

107107
[1]: https://app.datadoghq.com/rum/application/create
108108
[2]: https://raw.githubusercontent.com/DataDog/dd-sdk-reactnative/main/docs/image_reactnative.png

0 commit comments

Comments
 (0)