Skip to content

Commit 3e0244f

Browse files
authored
chore(ci): fix compilation for benchmark and fuzz targets (#150)
1 parent 8e11e46 commit 3e0244f

File tree

5 files changed

+25
-7
lines changed

5 files changed

+25
-7
lines changed

benchmark/CMakeLists.txt

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,14 @@ set(BENCHMARK_DOWNLOAD_DEPENDENCIES ON)
1515
set(BENCHMARK_ENABLE_TESTING OFF)
1616
add_subdirectory(google-benchmark)
1717

18-
target_link_libraries(dd_trace_cpp-benchmark benchmark::benchmark dd_trace_cpp-static)
18+
target_include_directories(dd_trace_cpp-benchmark
19+
PRIVATE
20+
${CMAKE_SOURCE_DIR}/src
21+
)
22+
23+
target_link_libraries(dd_trace_cpp-benchmark
24+
PRIVATE
25+
benchmark::benchmark
26+
dd_trace::static
27+
nlohmann_json::nlohmann_json
28+
)

benchmark/benchmark.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
#include <datadog/logger.h>
44
#include <datadog/span_data.h>
55
#include <datadog/tracer.h>
6-
#include <datadog/tracer_config.h>
76

8-
#include <datadog/json.hpp>
97
#include <memory>
108

119
#include "hasher.h"
@@ -34,7 +32,7 @@ struct SerializingCollector : public dd::Collector {
3432
}
3533

3634
std::string config() const override {
37-
return nlohmann::json::object({{"type", "SerializingCollector"}}).dump();
35+
return R"({"type": "SerializingCollector"})";
3836
}
3937
};
4038

benchmark/hasher.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include "hasher.h"
1616

1717
#include <datadog/span_config.h>
18-
#include <datadog/tags.h>
1918
#include <datadog/tracer.h>
2019
#include <datadog/tracer_config.h>
2120

@@ -97,8 +96,8 @@ int sha256_traced(Digest &digest, const fs::path &path,
9796
Digest hash;
9897
const fs::path &child = entry;
9998
if (sha256_traced(hash, child, span)) {
100-
span.set_error_message(
101-
"unable to calculate digest of " + child.u8string());
99+
span.set_error_message("unable to calculate digest of " +
100+
child.u8string());
102101
return 1;
103102
}
104103
children.emplace_back(child, hash);

fuzz/base64/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
add_executable(base64-fuzz main.cpp)
22

33
add_dependencies(base64-fuzz dd_trace_cpp-static)
4+
5+
target_include_directories(base64-fuzz
6+
PRIVATE
7+
${CMAKE_SOURCE_DIR}/src
8+
)
9+
410
target_link_libraries(base64-fuzz dd_trace_cpp-static)
511

612
add_target_to_group(base64-fuzz dd_trace_cpp-fuzzers)

fuzz/w3c-propagation/CMakeLists.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
add_executable(w3c-propagation-fuzz fuzz.cpp)
22

33
add_dependencies(w3c-propagation-fuzz dd_trace_cpp-static)
4+
5+
target_include_directories(w3c-propagation-fuzz
6+
PRIVATE
7+
${CMAKE_SOURCE_DIR}/src
8+
)
49
target_link_libraries(w3c-propagation-fuzz dd_trace_cpp-static)
510

611
add_target_to_group(w3c-propagation-fuzz dd_trace_cpp-fuzzers)

0 commit comments

Comments
 (0)