From 0879975af94aefa40cd7dbc2ee2b38985dba5a5d Mon Sep 17 00:00:00 2001
From: Yury Lebedev <yury.lebedev@datadoghq.com>
Date: Tue, 27 Aug 2024 15:20:17 +0200
Subject: [PATCH] Add test for Devise::Strategies::Rememberable patch

---
 .../patcher/authenticatable_patch_spec.rb     | 37 +++++++++++++++++--
 1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/spec/datadog/appsec/contrib/devise/patcher/authenticatable_patch_spec.rb b/spec/datadog/appsec/contrib/devise/patcher/authenticatable_patch_spec.rb
index 5c7f346dade..b40bcc2fb09 100644
--- a/spec/datadog/appsec/contrib/devise/patcher/authenticatable_patch_spec.rb
+++ b/spec/datadog/appsec/contrib/devise/patcher/authenticatable_patch_spec.rb
@@ -39,11 +39,11 @@ def initialize(id, email, username)
   let(:failed_login) {  mock_klass.new(false) }
 
   before do
-    expect(Datadog::AppSec).to receive(:enabled?).and_return(appsec_enabled)
+    allow(Datadog::AppSec).to receive(:enabled?).and_return(appsec_enabled)
     if appsec_enabled
-      expect(Datadog.configuration.appsec).to receive(:track_user_events).and_return(automated_track_user_events)
+      allow(Datadog.configuration.appsec).to receive(:track_user_events).and_return(automated_track_user_events)
 
-      expect(Datadog::AppSec).to receive(:active_scope).and_return(appsec_scope) if track_user_events_enabled
+      allow(Datadog::AppSec).to receive(:active_scope).and_return(appsec_scope) if track_user_events_enabled
     end
   end
 
@@ -67,7 +67,7 @@ def initialize(id, email, username)
     end
   end
 
-  context 'AppSec scope is nil ' do
+  context 'AppSec scope is nil' do
     let(:appsec_enabled) { true }
     let(:track_user_events_enabled) { true }
     let(:mode) { 'safe' }
@@ -79,6 +79,35 @@ def initialize(id, email, username)
     end
   end
 
+  context 'when logging in from Rememberable devise strategy' do
+    let(:appsec_enabled) { true }
+    let(:track_user_events_enabled) { true }
+    let(:appsec_scope) { instance_double(Datadog::AppSec::Scope, trace: double, service_entry_span: double) }
+
+    let(:mock_klass) do
+      Class.new do
+        def validate(resource, &block)
+          @result
+        end
+
+        alias_method :__validate, :validate
+
+        prepend Datadog::AppSec::Contrib::Devise::Patcher::AuthenticatablePatch
+        prepend Datadog::AppSec::Contrib::Devise::Patcher::RememberablePatch
+
+        def initialize(result)
+          @result = result
+        end
+      end
+    end
+
+    it 'does not track login event' do
+      expect(Datadog::AppSec::Contrib::Devise::Tracking).to_not receive(:track_login_success)
+
+      expect(success_login.validate(resource)).to eq(true)
+    end
+  end
+
   context 'successful login' do
     let(:appsec_enabled) { true }
     let(:track_user_events_enabled) { true }