Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch system-tests to python 3.12 #3764

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

cbeauchesne
Copy link
Contributor

What does this PR do?
Switch system-tests to python 3.12

Motivation:
System-tests won't support python 3.9 by end of month.

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jul 8, 2024
@cbeauchesne cbeauchesne marked this pull request as ready for review July 8, 2024 15:06
@cbeauchesne cbeauchesne requested a review from a team as a code owner July 8, 2024 15:06
@ivoanjo
Copy link
Member

ivoanjo commented Jul 8, 2024

I'm assuming this is one of those "if CI is green it's working fine?" or is there any kind of extra validation we can/should do?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (6e1050a) to head (2063564).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3764   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files        1241     1241           
  Lines       74714    74714           
  Branches     3605     3605           
=======================================
+ Hits        73157    73158    +1     
+ Misses       1557     1556    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbeauchesne
Copy link
Contributor Author

I'm assuming this is one of those "if CI is green it's working fine?" or is there any kind of extra validation we can/should do?

it's definitly that kind of PR 😄

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ivoanjo ivoanjo merged commit 66acc55 into master Jul 8, 2024
170 checks passed
@ivoanjo ivoanjo deleted the cbeauchesne/system-tests-3-12 branch July 8, 2024 16:14
@github-actions github-actions bot added this to the 2.2.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants