Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-TICKET] Switch libdatadog-crashtracking-receiver checks to wait_for #3766

Merged
merged 1 commit into from
Jul 9, 2024
+14 −7
Merged

[NO-TICKET] Switch libdatadog-crashtracking-receiver checks to wait_for #3766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions spec/datadog/profiling/crashtracker_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,13 @@
before do
skip_if_profiling_not_supported(self)

crash_tracker_pids = `pgrep -f libdatadog-crashtracking-receiver`
expect(crash_tracker_pids).to be_empty, "No crash tracker process should be running, found #{crash_tracker_pids}"
# No crash tracker process should still be running at the start of each testcase
wait_for { `pgrep -f libdatadog-crashtracking-receiver` }.to be_empty
end

after do
# No crash tracker process should still be running at the end of each testcase
wait_for { `pgrep -f libdatadog-crashtracking-receiver` }.to be_empty
end

let(:exporter_configuration) { [:agent, 'http://localhost:6006'] }
Expand Down Expand Up @@ -59,7 +64,7 @@
it 'starts the crash tracker' do
start

expect(`pgrep -f libdatadog-crashtracking-receiver`).to_not be_empty
wait_for { `pgrep -f libdatadog-crashtracking-receiver` }.to_not be_empty

crashtracker.stop
end
Expand All @@ -68,7 +73,7 @@
it 'only starts the crash tracker once' do
3.times { crashtracker.start }

expect(`pgrep -f libdatadog-crashtracking-receiver`.lines.size).to be 1
wait_for { `pgrep -f libdatadog-crashtracking-receiver`.lines.size }.to be 1

crashtracker.stop
end
Expand All @@ -95,13 +100,15 @@

it 'starts a second crash tracker for the fork' do
expect_in_fork do
wait_for { `pgrep -f libdatadog-crashtracking-receiver`.lines.size }.to be 1

crashtracker.reset_after_fork

expect(`pgrep -f libdatadog-crashtracking-receiver`.lines.size).to be 2
wait_for { `pgrep -f libdatadog-crashtracking-receiver`.lines.size }.to be 2

crashtracker.stop

expect(`pgrep -f libdatadog-crashtracking-receiver`.lines.size).to be 1
wait_for { `pgrep -f libdatadog-crashtracking-receiver`.lines.size }.to be 1
end
end
end
Expand All @@ -124,7 +131,7 @@

stop

expect(`pgrep -f libdatadog-crashtracking-receiver`).to be_empty
wait_for { `pgrep -f libdatadog-crashtracking-receiver` }.to be_empty
end
end

Expand Down
Loading