Use ActiveSupport events to instrument ActiveSupport::Cache #3772
+507
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
anmarchenko
approved these changes
Jul 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3607, fixes #3549, fixes #858
For tracing
ActiveSupport::Cache, this PR moves away from monkey-patching to subscribing toActiveSupport::Notificationsevents emitted by ActiveSupport Caching.We are still required to keep some monkey-patching to ensure backwards compatibility, and to support a few specific methods in old versions of Rails.
Motivation:
This improves the maintainability of the instrumentation, given the events we subscribe to are Rails' public APIs.
It is also more consistent across different caching backends (e.g. Redis, Memcached), allowing us to simplify our implementation.
How to test the change?
All changes are covered in the test suite.