Fix RSpec #log_deprecation matcher error when #log_deprecation uses :key

[delner]

What does this PR do?

#3675 added a limit feature to log_deprecation. However, leveraging this feature (by passing key: as an arg) will cause the use of the log_deprecation RSpec matcher to fail, because it explicitly expects no_args. This bug has no effect on production, only our test suite.

This feature loosens this constraint, allowing use of key args with log_deprecation and corresponding RSpec matcher.

Additional Notes:

This will also need to be backported to 1.x.

It would also be nice to augment the log_deprecation matcher to more explicitly handle the presence of a key arg in a way that tests the limitation set in place, aka expect { set_service_name }.to log_deprecation(include('service name')).with_limit(key: :deprecation_conf_service_name). However, this may not be an insignificant effort, and is out of scope for my efforts right now.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.91%. Comparing base (2a662b0) to head (ed52bfd).

Files	Patch %	Lines
spec/support/core_helpers.rb	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3781   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files        1246     1246           
  Lines       74999    74999           
  Branches     3627     3627           
=======================================
  Hits        73436    73436           
  Misses       1563     1563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.