Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-2334 Remove old ddtrace require from tracing benchmarks #3783

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

p-datadog
Copy link
Contributor

The library has been renamed to datadog,
this appears to be the last location where ddtrace is required in the test suite.

What does this PR do?

Removes fallback ddtrace require.

Motivation:

Code inspection

Additional Notes:

None

How to test the change?

Change is in the test suite

The library has been renamed to datadog,
this appears to be the last location where ddtrace
is required in the test suite.
@p-datadog p-datadog requested a review from a team as a code owner July 15, 2024 18:03
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Jul 15, 2024
@p-datadog p-datadog changed the title Remove old ddtrace require from tracing benchmarks DEBUG-2334 Remove old ddtrace require from tracing benchmarks Jul 15, 2024
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the cleanup

@p-datadog p-datadog merged commit 161e3eb into master Jul 16, 2024
170 checks passed
@p-datadog p-datadog deleted the tracing-benchmark-require branch July 16, 2024 13:58
@github-actions github-actions bot added this to the 2.3.0 milestone Jul 16, 2024
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request Jul 16, 2024
* master: (98 commits)
  DEBUG-2334 Remove old ddtrace require from tracing benchmarks (DataDog#3783)
  Avoid environment starts with number
  Add more variables for artifacts unpack
  `git fetch` before rev-parse
  Use ruby image that has `git` installed
  Provide versions
  Fixed: RSpec #log_deprecation matcher error when log is limited.
  Remove internal entry from changelog
  Update lockfiles for release 2.2.0
  Bump version 2.1.0 to 2.2.0
  Add 2.2.0 to CHANGELOG.md
  Add VSCode extension recommendations
  Add `ruby-lsp` gem
  [PROF-3760] Revert "Merge pull request DataDog#3760 from DataDog/ivoanjo/prof-10123-placeholder-missing-allocations"
  [PROF-10112] Also simplify actionview templates with three underscores
  remove duplicated comments
  Use ActiveSupport events to instrument ActiveSupport::Cache
  [PROF-10125] Track unscaled allocation counts in allocation profiler
  Bootstrap new profile value type for unscaled counts
  apply static analysis proposed fixes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants