-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unified Gitlab pipeline for APM libraries #3800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomanderson
added
dev/ci
Involves CircleCI, GitHub Actions, or GitLab
single-step
Single Step APM Instrumentation
labels
Jul 22, 2024
github-actions
bot
removed
the
dev/ci
Involves CircleCI, GitHub Actions, or GitLab
label
Jul 22, 2024
randomanderson
changed the title
Landerson/one pipeline
Use unified Gitlab pipeline for APM libraries
Jul 22, 2024
marcotc
approved these changes
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3800 +/- ##
==========================================
- Coverage 97.90% 97.90% -0.01%
==========================================
Files 1261 1261
Lines 75620 75620
Branches 3706 3706
==========================================
- Hits 74039 74035 -4
- Misses 1581 1585 +4 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
reviewed
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation:
How to test the change?
The changes were tested manually. CI/CD workflows are notoriously hard to test. Final products (OCI image and lib-init image) were run through automated onboarding tests.