DEBUG-2334 default token bucket allow? size to 1 #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only usage of token bucket rate limiter currently in our code uses a size of 1 (to perform one action). Default the size parameter to 1 to simplify the API for using token bucket on the caller side. Dynamic instrumentation will also use token bucket and will also call allow? with the size of 1.
p-datadog
force-pushed
the
token-bucket-size-1
branch
from
aa35d8a
to
2d10912
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3882 +/- ##
==========================================
+ Coverage 97.85% 97.87% +0.01%
==========================================
Files 1277 1277
Lines 76392 76403 +11
Branches 3744 3744
==========================================
+ Hits 74757 74779 +22
+ Misses 1635 1624 -11 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
Sep 3, 2024
|
I will merge this and it looks like #3886 is attempting to repair the ASM test failures. |
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Sep 6, 2024
* master: Add a check that ruleset file still exists to appsec:ruleset:update Add argument presence checks for appsec:ruleset:update Add Github Token as argument to appsec:ruleset:update task Add comments about deadlock risk Refactor with default level Refactor with Logger module DEBUG-2334 default token bucket allow? size to 1 (DataDog#3882) Fix system tests (DataDog#3883) Inject telemetry component Update gemfiles/* Add fiddle gem to Gemfile for Ruby >= 3.3 Add ostruct to Gemfile for Ruby >= 3.3
y9v
pushed a commit
that referenced
this pull request
Sep 13, 2024
The only usage of token bucket rate limiter currently in our code uses a size of 1 (to perform one action). Default the size parameter to 1 to simplify the API for using token bucket on the caller side. Dynamic instrumentation will also use token bucket and will also call allow? with the size of 1. Co-authored-by: Oleg Pudeyev <code@olegp.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The only usage of token bucket rate limiter currently in our code uses a size of 1 (to perform one action). Default the size parameter to 1 to simplify the API for using token bucket on the caller side.
Motivation:
Dynamic instrumentation will also use token bucket and will also call allow? with the size of 1.
Additional Notes:
How to test the change?
Unit tests