Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yard Github action #3918

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Fix Yard Github action #3918

merged 4 commits into from
Sep 18, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

The PR fixes the Github action for generating yard doc and uploaded to Github Pages.

It was broken due to: #3710, which I was trying to reduce the size of gemfile by removing redcarpet

To address this: I removed yard gem entirely from our Gemfile and migrate to a minimized Gemfile (yard.gemfile) under tools and updated the Github action with this dependency.

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Sep 17, 2024
@TonyCTHsu TonyCTHsu added this to the 2.4.0 milestone Sep 17, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 17, 2024 13:30
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 17, 2024 13:30
@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2024

Benchmarks

Benchmark execution time: 2024-09-17 14:27:19

Comparing candidate commit c20934b in PR branch tonycthsu/fix-yard with baseline commit 8f9f58c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

Copy link

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm not a ruby guild member so my review ain't worth much but this looks good to me thanks for fixing it @TonyCTHsu!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (8f9f58c) to head (c20934b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3918   +/-   ##
=======================================
  Coverage   97.85%   97.86%           
=======================================
  Files        1285     1285           
  Lines       76951    76951           
  Branches     3789     3789           
=======================================
+ Hits        75302    75308    +6     
+ Misses       1649     1643    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rakefile Show resolved Hide resolved
@TonyCTHsu TonyCTHsu merged commit a0b9273 into master Sep 18, 2024
193 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-yard branch September 18, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants