-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Yard Github action #3918
Fix Yard Github action #3918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'm not a ruby guild member so my review ain't worth much but this looks good to me thanks for fixing it @TonyCTHsu!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3918 +/- ##
=======================================
Coverage 97.85% 97.86%
=======================================
Files 1285 1285
Lines 76951 76951
Branches 3789 3789
=======================================
+ Hits 75302 75308 +6
+ Misses 1649 1643 -6 ☔ View full report in Codecov by Sentry. |
What does this PR do?
The PR fixes the Github action for generating yard doc and uploaded to Github Pages.
It was broken due to: #3710, which I was trying to reduce the size of gemfile by removing
redcarpet
To address this: I removed
yard
gem entirely from our Gemfile and migrate to a minimized Gemfile (yard.gemfile
) undertools
and updated the Github action with this dependency.