Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set both permission for milestone action #3920

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 17, 2024

What does this PR do?

Requires both issues and pull-requests write permission

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 17, 2024 15:40
@TonyCTHsu TonyCTHsu added dev/testing Involves testing processes (e.g. RSpec) dev/github Github repository maintenance and automation labels Sep 17, 2024
@github-actions github-actions bot removed the dev/testing Involves testing processes (e.g. RSpec) label Sep 17, 2024
@github-actions github-actions bot added this to the 2.4.0 milestone Sep 17, 2024
This reverts commit 369b26a.
@TonyCTHsu TonyCTHsu enabled auto-merge (squash) September 17, 2024 15:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (fba228d) to head (159be4c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3920      +/-   ##
==========================================
- Coverage   97.86%   97.85%   -0.01%     
==========================================
  Files        1285     1285              
  Lines       76951    76951              
  Branches     3789     3789              
==========================================
- Hits        75306    75301       -5     
- Misses       1645     1650       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit 7c84edb into master Sep 17, 2024
166 of 168 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-milestone-action branch September 17, 2024 16:17
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request Sep 18, 2024
* master:
  DEBUG-2334 Dynamic instrumentation configuration (DataDog#3917)
  Update Gemfiles
  Set both permission for milestone action (DataDog#3920)
  Rename variable
  Lint
  Add tools to excluded test
  Update gemfiles
  Extract yard
  Comment
  Task for updating latest group
  Allow GraphQL integration reconfiguration
  Change the way how login tracking is disabled for Rememberable strategy
  Rename __validate alias to __validate_datadog_authenticatable
  Add sig file for RememberablePatch
  Add test for Devise::Strategies::Rememberable patch
  Add AppSec patcher for Devise Rememberable strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants