Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-2334 add types for dynamic instrumentation settings #3924

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

p-datadog
Copy link
Contributor

What does this PR do?

This PR adds sig files for dynamic instrumentation settings.

Motivation:

Perform additional type checks.

Additional Notes:

How to test the change?
Existing tests.

Unsure? Have a question? Request a review!

@p-datadog p-datadog requested a review from a team as a code owner September 18, 2024 20:24
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Benchmark execution time: 2024-09-18 21:21:07

Comparing candidate commit fd67115 in PR branch di-settings-sig with baseline commit f6ec8b7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (f6ec8b7) to head (fd67115).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3924      +/-   ##
==========================================
- Coverage   97.78%   97.78%   -0.01%     
==========================================
  Files        1291     1291              
  Lines       77149    77149              
  Branches     3810     3810              
==========================================
- Hits        75440    75438       -2     
- Misses       1709     1711       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-datadog p-datadog merged commit e97a23c into master Sep 19, 2024
192 of 193 checks passed
@p-datadog p-datadog deleted the di-settings-sig branch September 19, 2024 11:56
@github-actions github-actions bot added this to the 2.4.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants