Split single step instrument entry point #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/ssi-entry-point
branch
from
f96071d
to
e090ee6
Compare
BenchmarksBenchmark execution time: 2024-09-20 17:05:11 Comparing candidate commit 8b71df7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3931 +/- ##
==========================================
- Coverage 97.77% 97.75% -0.02%
==========================================
Files 1297 1297
Lines 77611 77611
Branches 3871 3871
==========================================
- Hits 75881 75868 -13
- Misses 1730 1743 +13 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
force-pushed
the
tonycthsu/ssi-entry-point
branch
from
f69aac5
to
015d492
Compare
TonyCTHsu
force-pushed
the
tonycthsu/ssi-entry-point
branch
from
015d492
to
8b71df7
Compare
TonyCTHsu
added
single-step
marcotc
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For single step instrumentation, use a different entry point that would rescue
LoadErrorand not crash the process.