Rescue instrumentation errors #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3951 +/- ##
==========================================
- Coverage 97.85% 97.84% -0.01%
==========================================
Files 1303 1307 +4
Lines 78139 78229 +90
Branches 3894 3894
==========================================
+ Hits 76461 76543 +82
- Misses 1678 1686 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TonyCTHsu
force-pushed
the
tonycthsu/rescue-error
branch
from
a18f5d4
to
24eebe9
Compare
TonyCTHsu
added
the
dev/internal
marcotc
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rescue instrumentation errors.
Motivation:
During instrumentation, we often annotate the span or trace based on the data available. There are risk that the assumption of existing data are not met.
For instance,
ActiveSupport::Notificationsevent, might not carry your expected data.This PR tries to rescue them and fail gracefully. It is not a silver bullet. We still need to expand our test coverage to catch those failures (example: 93438f4)