Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][dinky-flink] Will version 1.0 support flink 1.13 in the future? #3171

Closed
2 of 3 tasks
nianhua99 opened this issue Feb 22, 2024 · 4 comments
Closed
2 of 3 tasks
Labels
Invalid Invalid Wont Fix This will not be worked on

Comments

@nianhua99
Copy link

nianhua99 commented Feb 22, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Now, version 1.0 supports Flink versions 1.14-1.18, and we previously used version 0.7 of Dinky and version 1.13 of Flink

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@nianhua99 nianhua99 added New Feature New feature Waiting for reply Waiting for reply labels Feb 22, 2024
@Zzm0809
Copy link
Contributor

Zzm0809 commented Feb 22, 2024

In dinky version 1.0 and later versions, only up to 5 versions are retained, that is, every time Flink adds a new version, dinky will eliminate one version.

@Zzm0809 Zzm0809 added Invalid Invalid Wont Fix This will not be worked on and removed Waiting for reply Waiting for reply New Feature New feature labels Feb 22, 2024
Copy link

Hello @nianhua99, thank you for your feedback, but this issue will not be fixed. You can search for keywords in the Issue list to view it. Issues are marked `Wont Fix`

你好 @nianhua99, 感谢你的反馈, 但是此问题不会被修复,你可以在 Issue 列表中搜索关键字来查看, Issues 标注为 `Wont Fix` 。

@nianhua99
Copy link
Author

In dinky version 1.0 and later versions, only up to 5 versions are retained, that is, every time Flink adds a new version, dinky will eliminate one version.

Can I add flink 1.13 back in the dinky-flink module by myself?

@Zzm0809
Copy link
Contributor

Zzm0809 commented Feb 26, 2024

In dinky version 1.0 and later versions, only up to 5 versions are retained, that is, every time Flink adds a new version, dinky will eliminate one version.

Can I add flink 1.13 back in the dinky-flink module by myself?

Of course , but you need to develop it yourself and solve a series of problems in the process. You can refer to other sub-modules under the dinky-flink module and dinky-client module for development.

@Zzm0809 Zzm0809 closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid Invalid Wont Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants