Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The delete usage method doesn't return a boolean result #49

Closed
taojing2002 opened this issue Jul 7, 2020 · 3 comments
Closed

The delete usage method doesn't return a boolean result #49

taojing2002 opened this issue Jul 7, 2020 · 3 comments
Assignees

Comments

@taojing2002
Copy link
Contributor

In our design document, the delete usage method should return a boolean result. However, it return a blank string.

@gothub gothub self-assigned this Jul 7, 2020
@gothub
Copy link
Collaborator

gothub commented Jul 7, 2020

@taojing2002 the delete usage service returns an HTTP status of 200 if the request is successful, or an error status if it isn't
successful. Is that sufficient?

@taojing2002
Copy link
Contributor Author

@gothub To me, it is fine. I just concern it doesn't match our design document -

boolean   = deleteUsage():  DELETE  /usage/:id

If we all have an agreement that we don't need to return the boolean, it is totally fine to me.

@gothub
Copy link
Collaborator

gothub commented Jul 7, 2020

@taojing2002
The bookkeeper delete methods for all resources ("customers", "products", ...) all return HTTP 200 on success, so I'd say let's go with that.

I just opened issue #50 for creating a Swagger definition for the bookkeeper API. When this is created, this should be the reference for the bookkeeper API.

@gothub gothub closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants