Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseXPathDocumentSubprocessor shares XPathFactory #22

Open
taojing2002 opened this issue Aug 28, 2022 · 1 comment
Open

BaseXPathDocumentSubprocessor shares XPathFactory #22

taojing2002 opened this issue Aug 28, 2022 · 1 comment

Comments

@taojing2002
Copy link
Collaborator

In BaseXPathDocumentSubprocessor, there are two class fields:

private static XPathFactory xpathFactory = null;
private static XPath xpath = null;

However, XpathFactory is not thread-safe and it shouldn't be a class field. But the code is running for a long time without issues.

@mbjones mbjones modified the milestones: 2.4.0, 3.0.0 Sep 6, 2022
@mbjones
Copy link
Member

mbjones commented Dec 7, 2022

Likely only a problem when we run more than one thread within an IndexWorker, so unlikely to be an issue in our k8s deployment. But leaving this open to triage and potentially fix in the future if it might be a problem in other deployment scenarios.

@mbjones mbjones removed this from the 3.0.0 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants