-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add JSDoc types to fs-utils package #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add comprehensive JSDoc type annotations to all exported functions - Create tsconfig.json configured for declaration-only output - Add TypeScript and Node.js types as devDependencies - Add 'types' npm script that runs tsc to emit TypeScript declarations - Generate TypeScript declarations in types/index.d.ts Closes #6 Co-authored-by: DavidWells <DavidWells@users.noreply.github.com>
|
Looks good! now we need to add tests for all the functions we export from this library setup tests using the uvu npm package and verify that our FS calls work as intended @claude |
|
Claude finished @DavidWells's task in 2m 52s —— View job Setting up tests for util-fs package ✅I've successfully added comprehensive tests using uvu for all the functions exported from the util-fs package. Todo List:
Functions tested:✅ Test coverage includes:
Changes made:
The test suite is ready to run with |
- Add uvu testing framework as dev dependency - Add test script to package.json - Create comprehensive test suite covering all exported functions: - fileExists and directoryExists - writeFile, readFile, copyFile, deleteFile - createDir, readDir, copyDir, deleteDir - getFileSize with bytes and MB calculations - Include tests for edge cases and error handling - Test recursive operations and filtering options - Verify ENOENT error handling in deleteFile Co-authored-by: DavidWells <DavidWells@users.noreply.github.com>
|
@claude run the tests to verify they work |
|
Claude finished @DavidWells's task in 2m 6s —— View job Running tests for util-fs package ✅Todo List:
Test Results:✅ All 23 tests now pass! Issue Found and Fixed:The
Solution Applied:
Final Status:
The util-fs package test suite is working perfectly and ready for production use! |
…lculation The test was failing because 1000 bytes rounds to 0.00 MB when rounded to 2 decimal places, making the assertion `size.mb > 0` fail. Updated to use 100000 bytes (~0.1 MB) instead. Co-authored-by: DavidWells <DavidWells@users.noreply.github.com>
|
ok great make sure the JSdocs are still correct and add information about the fs utilities available in the README.md of this package Also rebase this on master if you need to so we can finally merge this thanks @claude |
|
💬 Claude Code execution complete ✅ 📊 Execution Info: Pull Request #7 | React (271 files) | @DavidWells |
|
Claude finished @DavidWells's task —— View job Finalized util-fs package documentation ✅I've successfully updated the JSDoc annotations and created comprehensive README documentation for the util-fs package. Completed Tasks:
Changes Made:1. Enhanced JSDoc (index.js)
2. Comprehensive README.md
|
- Add proper JSDoc type annotations for writeFile, readFile, and copyFile - Create comprehensive README.md with detailed API documentation - Document all 11 exported functions with parameters, return types, and examples - Add usage examples for common scenarios - Include TypeScript support information - Add testing section Co-authored-by: David Wells <DavidWells@users.noreply.github.com>
Add comprehensive JSDoc type annotations and TypeScript declaration generation to the util-fs package.
Changes
Closes #6
Generated with Claude Code