From 995874e94d9f4bf6070499ef7517b92b953e3e76 Mon Sep 17 00:00:00 2001 From: Nicolas Martinos Date: Wed, 2 Aug 2023 14:14:59 +0300 Subject: [PATCH 1/3] refactor: replaces assign() polyfill --- addon/services/raven.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/addon/services/raven.js b/addon/services/raven.js index 30bee8b..9f5a837 100644 --- a/addon/services/raven.js +++ b/addon/services/raven.js @@ -1,7 +1,6 @@ /* eslint-disable ember/avoid-leaking-state-in-ember-objects */ import Ember from 'ember'; -import { assign as _assign, merge } from '@ember/polyfills'; import Service from '@ember/service'; import { set } from '@ember/object'; import { typeOf, isPresent } from '@ember/utils'; @@ -9,10 +8,6 @@ import { typeOf, isPresent } from '@ember/utils'; import RSVP from 'rsvp'; import Raven from 'raven'; -// Ember merge is deprecated as of 2.5, but we need to check for backwards -// compatibility. -const assign = _assign || merge; - /** * Default available logger service. * @@ -97,7 +92,7 @@ export default Service.extend({ Raven.debug = debug; // Keeping existing config values for includePaths, whitelistUrls, for compatibility. - const ravenConfig = assign({ + const ravenConfig = Object.assign({ environment, includePaths, whitelistUrls, From e0186461291798da658319d7dcfa8c4f33995cba Mon Sep 17 00:00:00 2001 From: Nicolas Martinos Date: Wed, 2 Aug 2023 14:26:36 +0300 Subject: [PATCH 2/3] chore: adds GH test workflow --- .github/workflows/test.yml | 22 ++++++++++++++++++++++ .gitignore | 1 + 2 files changed, 23 insertions(+) create mode 100644 .github/workflows/test.yml diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml new file mode 100644 index 0000000..efeec32 --- /dev/null +++ b/.github/workflows/test.yml @@ -0,0 +1,22 @@ +name: Test + +on: + push: + branches: + - master + pull_request: {} + +jobs: + test: + name: Test + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v2 + with: + node-version: 16 + cache: yarn + - run: yarn install + - run: yarn lint:js + - run: yarn test \ No newline at end of file diff --git a/.gitignore b/.gitignore index 8fa39a6..c093d80 100644 --- a/.gitignore +++ b/.gitignore @@ -16,6 +16,7 @@ npm-debug.log* yarn-error.log testem.log +./DS_Store # ember-try .node_modules.ember-try/ From 7e38c4682588abd237f155d6e95b77cb64e35d41 Mon Sep 17 00:00:00 2001 From: Nicolas Martinos Date: Wed, 2 Aug 2023 14:43:50 +0300 Subject: [PATCH 3/3] chore: updates ember-try config --- config/ember-try.js | 73 ++------------------------------------------- 1 file changed, 3 insertions(+), 70 deletions(-) diff --git a/config/ember-try.js b/config/ember-try.js index 0c2bc2f..e396cc0 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -2,45 +2,10 @@ module.exports = { useYarn: true, scenarios: [ { - name: 'ember-lts-2.4', - bower: { - dependencies: { - 'ember': 'components/ember#lts-2-4' - }, - resolutions: { - 'ember': 'lts-2-4' - } - }, - npm: { - devDependencies: { - 'ember-source': null - } - } - }, - { - name: 'ember-lts-2.8', - bower: { - dependencies: { - 'ember': 'components/ember#lts-2-8' - }, - resolutions: { - 'ember': 'lts-2-8' - } - }, - }, - { - name: 'ember-lts-2.12', - npm: { - devDependencies: { - 'ember-source': '~2.12.0' - } - } - }, - { - name: 'ember-lts-2.16', + name: 'ember-lts-3.12', npm: { devDependencies: { - 'ember-source': '~2.16.0' + 'ember-source': '~3.12.0' } } }, @@ -60,38 +25,6 @@ module.exports = { } } }, - { - name: 'ember-beta', - bower: { - dependencies: { - 'ember': 'components/ember#beta' - }, - resolutions: { - 'ember': 'beta' - } - }, - npm: { - devDependencies: { - 'ember-source': null - } - } - }, - { - name: 'ember-canary', - bower: { - dependencies: { - 'ember': 'components/ember#canary' - }, - resolutions: { - 'ember': 'canary' - } - }, - npm: { - devDependencies: { - 'ember-source': null - } - } - }, { name: 'ember-default', npm: { @@ -99,4 +32,4 @@ module.exports = { } } ] -}; +}