Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs snippets are not displayed correctly #221

Open
BlueCutOfficial opened this issue Dec 12, 2023 · 0 comments
Open

Diffs snippets are not displayed correctly #221

BlueCutOfficial opened this issue Dec 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@BlueCutOfficial
Copy link
Member

BlueCutOfficial commented Dec 12, 2023

How to reproduce

First insights

The diff colors are managed in app.scss, you can find the place by searching code[data-diff] in the code.

In the English version, the code lines are embedded in <span class="diff-deletion"> and <span class="diff-insertion"> elements, which is what the CSS applied to. But in the French guides, the generated HTML is wrong and we don't have such elements, so the CSS is unused.

ember-showdown-prism seems related to the generation of the HTML, our custom Guidemaker template uses a non-up-to-date version.
Today, ember-learn/guidemaker-ember-template uses different dependencies. See also https://discord.com/channels/480462759797063690/480777444203429888/1255605726622122044

@BlueCutOfficial BlueCutOfficial added the bug Something isn't working label Dec 12, 2023
BlueCutOfficial pushed a commit that referenced this issue Oct 4, 2024
* Find/replace Ember Data for EmberData

This is now the standard naming and branding for the library.

* add EmberData to local dictionary

---------

Co-authored-by: Chris Manson <chris@manson.ie>

---

Commit:  ember-learn/super-rentals-tutorial@bc1791c
Script:  https://github.com/ember-learn/super-rentals-tutorial/blob/bc1791c3b207f4d2941acbaca854cfbe1ad1a2ac/.github/workflows/build.yml
Logs:    https://github.com/ember-learn/super-rentals-tutorial/commit/bc1791c3b207f4d2941acbaca854cfbe1ad1a2ac/checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant