Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint from 8.57.0 to 9.7.0 #206

Open
BlueCutOfficial opened this issue Jul 23, 2024 · 3 comments · May be fixed by #207
Open

Bump eslint from 8.57.0 to 9.7.0 #206

BlueCutOfficial opened this issue Jul 23, 2024 · 3 comments · May be fixed by #207
Assignees

Comments

@BlueCutOfficial
Copy link
Member

The Dependabot PR failed because this is a major version that changes entirely the config format for ESLint.
We should do this upgrade ourselves following the migration guide: https://eslint.org/docs/latest/use/configure/migration-guide

@BlueCutOfficial BlueCutOfficial self-assigned this Jul 23, 2024
@BlueCutOfficial
Copy link
Member Author

BlueCutOfficial commented Jul 23, 2024

After using the codemod to generate eslint.config.mjs, I ran into the following error when running the linter:

Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace

This error comes from the globals package itself. We rely on a version that literally contains the said typo. The latest version (15.8.0) has been fixed. Using yarn resolutions to force the usage of a fixed version solves the linter issue.

@BlueCutOfficial
Copy link
Member Author

BlueCutOfficial commented Jul 23, 2024

The next problem is:

TypeError: context.getAncestors is not a function
Occurred while linting /Users/marine/Desktop/Repos/opensource/dazzlingfugu/ember-reading-time/.stylelintrc.js
Rule: "ember/require-return-from-computed"
  at onCodePathStart (/Users/marine/Desktop/Repos/opensource/dazzlingfugu/ember-reading-time/node_modules/eslint-plugin-ember/lib/rules/require-return-from-computed.js:70:16)

Unfortunately, this issue is currently blocked by eslint-plugin-ember not supporting every aspect of ESLint 9. The specific problem above should be fixed with eslint-plugin-ember#2153 (will close eslint-plugin-ember#2136) but it hasn't been released yet.

@BlueCutOfficial BlueCutOfficial linked a pull request Jul 23, 2024 that will close this issue
@LucasHill
Copy link

LucasHill commented Aug 7, 2024

Just a note that my fix wasn't complete, but it does open up using a workaround to getting the ember plugin running in v9.
ember-cli/eslint-plugin-ember#2136 (comment) if they decide to release at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants