-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto_name works even when it's not supposed to #106
Comments
Update: that also affects release Military Bring Item quests that do have unique names specified for them but never use them, despite auto_name being set to false by default. |
Here is the logic in scripts\task_objects.script that governs what name a task receives:
In the code above, |
That would be because of this code in task_objects.script:
|
As visible from the code above, the 'Recover item' quest names (apparently, not just for Military Warehouses but for other locations as well) should use unique names if |
As with 'Bring Item' - is it unclear whether it's intended behaviour or more of an oversight? These lines are in configuration files, I suppose they should be used. |
Unlike cut Deliver items quests at Cordon, Garbage, Agroprom and Military Warehouses, the ones at Swamps have unique text strings associated with them. I am pretty sure these quests having unique titles and descriptions in PDA was what GSC intended since these texts are not just left in the game files, they are referenced in quest configs.
And title is used in a news part that appears when you get the quest:
![image](https://user-images.githubusercontent.com/35204405/81224952-25a9d980-8ff1-11ea-95d8-9f9aa6654a48.png)
However, for some reason, neither the title nor the description is present when you hover over the quest in PDA:
![image](https://user-images.githubusercontent.com/35204405/81225109-6144a380-8ff1-11ea-980a-c778f3fa5ced.png)
At first I thought it's a basic oversight with
auto_name
. Having no idea if it's defaulted to True or False, I tried both, and nothing changed. Neither in vanilla nor in SRP.Related: the same bug also happened when I tried to restore two cut Agroprom quests - Find the dead stalker's loot and Find the missing stalker. Both of these quests do have unique titles but if you restore them, 'Return Item: %Item%' gets displayed instead.
The text was updated successfully, but these errors were encountered: