[BUG] Token Icon Not Updating Properly After PR Merge on Ethereum Lists #1450
Comments
|
Hey @AndyBoWu we only show the logo for chain that are already listed on DefiLlama |
|
Hey @AndyBoWu thanks for bringing this up. We currently only add the logos to note chains that have already been listed on DefiLlama. Are there any Defi projects live on Story? We'd love to get it listed |
|
8 December 2024 |
|
@realdealshaman , we'll have a few projects live very soon. |
Setland34
added a commit
to DeepmindGoogle/chainlist
that referenced
this issue
Jan 16, 2025
Fixes DefiLlama#1450 Update the token icon URL handling in `components/chain/index.js`. * **Icon URL Update**: Modify the icon URL to use the correct path for the token icon. * **Fallback Mechanism**: Add a fallback mechanism to check if the icon exists and use a default icon if it doesn't. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DefiLlama/chainlist/issues/1450?shareId=XXXX-XXXX-XXXX-XXXX).
Setland34
added a commit
to DeepmindGoogle/chainlist
that referenced
this issue
Jan 16, 2025
Fixes DefiLlama#1450 Update the icon URL validation in `components/RPCList/index.js`. * **Add URL validation function**: Add a function `isValidUrl` to check if the icon URL is valid. * **Update icon URL display logic**: Modify the logic to display the icon URL only if it is valid. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DefiLlama/chainlist/issues/1450?shareId=XXXX-XXXX-XXXX-XXXX).
Setland34
added a commit
to DeepmindGoogle/chainlist
that referenced
this issue
Jan 16, 2025
Fixes DefiLlama#1450 Update the icon URL validation in `components/RPCList/index.js`. * **Add URL validation function**: Add a function `isValidUrl` to check if the icon URL is valid. * **Update icon URL display logic**: Modify the logic to display the icon URL only if it is valid. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DefiLlama/chainlist/issues/1450?shareId=XXXX-XXXX-XXXX-XXXX).
Setland34
added a commit
to DeepmindGoogle/chainlist
that referenced
this issue
Jan 16, 2025
Related to DefiLlama#1450 Update the token icon URL handling and validation in `components/RPCList/index.js`. * **Add icon URL validation**: Add a function `isValidIconUrl` to check if the icon URL is valid before displaying it. * **Set icon URL**: Define the icon URL using `chain.chainSlug`. * **State management**: Add state `validIconUrl` to manage the validity of the icon URL. * **Effect hook**: Use `useEffect` to validate the icon URL and update the state accordingly. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DefiLlama/chainlist/issues/1450?shareId=XXXX-XXXX-XXXX-XXXX).
Setland34
added a commit
to Setland34/chainlist
that referenced
this issue
Jan 16, 2025
Fixes DefiLlama#1450 Update the token icon URL handling and validation in `components/RPCList/index.js`. * **Add icon URL validation**: Add a function `isValidIconUrl` to check if the icon URL is valid before displaying it. * **Set icon URL**: Define the icon URL using `chain.chainSlug`. * **State management**: Add state `validIconUrl` to manage the validity of the icon URL. * **Effect hook**: Use `useEffect` to validate the icon URL and update the state accordingly. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DefiLlama/chainlist/issues/1450?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Original ticket: ethereum-lists/chains#6497
and I did some checking to other newly registered chains too, this seems like a common issue on the front end.
The text was updated successfully, but these errors were encountered: