Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax water level requirements when opening a lock in phase wise operation #60

Open
erwin-mulder opened this issue Jan 16, 2025 · 0 comments
Assignees

Comments

@erwin-mulder
Copy link
Collaborator

In phase wise operation with D-Flow FM, the head level may have been changed relative to the lock after 'leveling' in a previous timestep. This causes an assert to fail and the calculation not to continue.

TODO:

  • Remove the assert (and thus allow the levels to differ)
  • Introduce a a warning if there is a difference, larger than a parameter (to be introduced).
  • For operation in D-Flow FM, make the allowed difference configurable in the .ini file.
  • For operation in D-Flow FM, the default allowed difference should be 10 cm (if not configured)
@erwin-mulder erwin-mulder self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant