Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSheet] Missing feature for setting vertical balance parameters #180

Closed
KentropDevelopment opened this issue Apr 29, 2024 · 2 comments
Closed

Comments

@KentropDevelopment
Copy link
Contributor

There is no method for setting the maximum point resistance and xi factor that are needed for calculation the vertical balance.

The current work-around is setting the vertical balance properties directly as a string via model.datastructure.input_data.vertical_balance.

I've created functionality for setting these parameters but I think I need to be assigned as a contributer in order to create a new branch. Could you add me as a contributer?

Regards,
Daniël Kentrop

image

@wfaustmann
Copy link
Collaborator

Hi Daniël,

Good to hear that your want to make your first contribution. There is no need to add you as a contributor. By creating a pull request, you can create a branch yourself. When your commits are done, we will review the code and we merge the pull request upon approval.

Please let me know, if you have any questions.

Regards,
Walter

@KentropDevelopment
Copy link
Contributor Author

Hi Walter,

Thanks for your explanation! I made a pull request #182 which fixes this issue. It is ready for review. Let me know if I should change or add anything.

Regards,
Daniël

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants