Revert "use ForcingData class as a type for the discharge, temperature, and salinity in the SourceSink class"

This reverts commit 89b55a0

Signed-off-by: Mostafa Farrag <moah.farag@gmail.com>

Author: MAfarrag

hydrolib/core/dflowfm/bc/models.py

@@ -845,7 +845,7 @@ class RealTime(StrEnum):
     """str: Realtime data source, externally provided"""
 
 
-ForcingData = Union[float, List[float], RealTime, ForcingModel]
+ForcingData = Union[float, RealTime, ForcingModel]
 """Data type that selects from three different types of forcing data:
 *   a scalar float constant
 *   "realtime" keyword, indicating externally controlled.

hydrolib/core/dflowfm/ext/models.py

@@ -210,11 +210,13 @@ class SourceSink(INIBasedModel):
 
     zsource: Optional[Union[float, List[float]]] = Field(alias="zSource")
     zsink: Optional[Union[float, List[float]]] = Field(alias="zSink")
-    discharge: ForcingData = Field(alias="discharge")
+    discharge: Union[float, List[float]] = Field(alias="discharge")
     area: Optional[float] = Field(alias="Area")
 
-    salinitydelta: Optional[ForcingData] = Field(alias="SalinityDelta")
-    temperaturedelta: Optional[ForcingData] = Field(alias="TemperatureDelta")
+    salinitydelta: Optional[Union[List[float], float]] = Field(alias="SalinityDelta")
+    temperaturedelta: Optional[Union[List[float], float]] = Field(
+        alias="TemperatureDelta"
+    )
 
     @classmethod
     def _exclude_from_validation(cls, input_data: Optional[dict] = None) -> Set: