Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate Sample Sizes endpoint seems to skip canonicalization step #235

Open
vteague opened this issue Feb 6, 2025 · 5 comments · May be fixed by #240
Open

Estimate Sample Sizes endpoint seems to skip canonicalization step #235

vteague opened this issue Feb 6, 2025 · 5 comments · May be fixed by #240
Assignees
Labels
Bug Something isn't working

Comments

@vteague
Copy link
Member

vteague commented Feb 6, 2025

During estimate sample sizes, the canonicalization step seems to be skipped.

Not clear whether this is a client issue or a server issue.

@vteague vteague added the Bug Something isn't working label Feb 6, 2025
@vteague vteague added this to the Testing Complete milestone Feb 6, 2025
@vteague vteague moved this to Todo in CO IRV RLA Feb 6, 2025
@vteague vteague self-assigned this Feb 14, 2025
@vteague
Copy link
Member Author

vteague commented Feb 14, 2025

Notes to replicate:

I used resources/workflows/Boulder_loadCVRs.http and demo1_loadCVRs.http, then stepped through defining the audit via the client.

First note that if the manifests are uploaded (via Boulder_loadManifest.http and demo1_loadManifests.http), the canonicalization step is not skipped, because the demo1-canonical-list.csv demands standardized contest names for Boulder Mayoral, Boulder Council, Layafette Council and U-CO Regent in Adams and Alamosa.

@vteague
Copy link
Member Author

vteague commented Feb 14, 2025

Also Jorge Chavez's name needs to be canonicalized in Boulder Valley School District.

@vteague
Copy link
Member Author

vteague commented Feb 14, 2025

Canonicalization follows from the upload of the canonical list csv and precedes assertion generation, as it should.

@vteague
Copy link
Member Author

vteague commented Feb 14, 2025

Now repeating with only manifests.
The `Standardize Contest Names' step says "waiting for counties to upload contest data". The "Save & Next" button is disabled.

@vteague vteague moved this from Todo to In Progress in CO IRV RLA Feb 20, 2025
@vteague
Copy link
Member Author

vteague commented Feb 20, 2025

Update: I've got this working and put in a draft PR so people can easily see where it's up to:
#240
I'm pretty happy with the (very minor) changes to the colorado-rla endpoint, though I still need to add some basic tests.
However, the client changes are just a prototype, and it'd be good if @charliecarlton could take a look and possibly think about a better way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: In Progress
2 participants