Skip to content

Commit 4cdaaa5

Browse files
List: the height of a scrollable wrapper in Fluent theme should be correctly calculated when a search bar exists (T1218632) (#26747)
1 parent 709dfd1 commit 4cdaaa5

File tree

5 files changed

+30
-1
lines changed

5 files changed

+30
-1
lines changed

packages/devextreme/scss/widgets/fluent/list/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ $fluent-list-item-border: $fluent-list-item-border-width solid $list-border-colo
148148
}
149149

150150
&.dx-list-with-search .dx-scrollable-wrapper {
151-
height: calc(100% - #{$fluent-list-item-height + $fluent-texteditor-input-height + $fluent-list-searchbox-margin-bottom});
151+
height: calc(100% - #{$fluent-texteditor-input-height + $fluent-list-searchbox-margin-bottom});
152152
}
153153

154154
.dx-empty-message {
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
import { createScreenshotsComparer } from 'devextreme-screenshot-comparer';
2+
import { testScreenshot } from '../../../helpers/themeUtils';
3+
import url from '../../../helpers/getPageUrl';
4+
import { createWidget } from '../../../helpers/createWidget';
5+
6+
fixture.disablePageReloads`Search`
7+
.page(url(__dirname, '../../container.html'));
8+
9+
test('List with search bar appearance', async (t) => {
10+
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
11+
await t.debug();
12+
await testScreenshot(t, takeScreenshot, 'List with search bar appearance.png', { element: '#container' });
13+
14+
await t
15+
.expect(compareResults.isValid())
16+
.ok(compareResults.errorMessages());
17+
}).before(async () => {
18+
const dataSource = Array.from({ length: 40 }, (_, i) => `Item_${i + 1}`);
19+
20+
return createWidget('dxList', {
21+
dataSource,
22+
height: 400,
23+
width: 200,
24+
searchEnabled: true,
25+
showSelectionControls: true,
26+
selectionMode: 'all',
27+
selectByClick: false,
28+
});
29+
});

0 commit comments

Comments
 (0)