Skip to content

Commit 4f3e2be

Browse files
authored
🛠️ Refactoring | Grid native classes: validating (#26762)
1 parent 804eb6c commit 4f3e2be

File tree

6 files changed

+554
-520
lines changed

6 files changed

+554
-520
lines changed

packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1965,7 +1965,7 @@ class EditingControllerImpl extends modules.ViewController {
19651965
}
19661966
}
19671967

1968-
_needUpdateRow(column) {
1968+
_needUpdateRow(column?) {
19691969
const visibleColumns = this._columnsController.getVisibleColumns();
19701970

19711971
if (!column) {

packages/devextreme/js/__internal/grids/grid_core/editing/m_editing_form_based.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ const editingControllerExtender = (Base: ModuleType<EditingController>) => class
181181
.appendTo(this.component.$element())
182182
.addClass(editPopupClass);
183183

184-
// @ts-expect-error
185184
this._editPopup = this._createComponent($popupContainer, Popup);
186185
this._editPopup.on('hiding', this._getEditPopupHiddenHandler());
187186
this._editPopup.on('shown', (e) => {
@@ -214,7 +213,6 @@ const editingControllerExtender = (Base: ModuleType<EditingController>) => class
214213

215214
return (container) => {
216215
const formTemplate = this.getEditFormTemplate();
217-
// @ts-expect-error
218216
const scrollable = this._createComponent($('<div>').appendTo(container), Scrollable);
219217

220218
this._$popupContent = $((scrollable as any).content());

packages/devextreme/js/__internal/grids/grid_core/header_panel/m_header_panel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export class HeaderPanel extends ColumnsView {
119119
$headerPanel.addClass(this.addWidgetPrefix(HEADER_PANEL_CLASS));
120120
const label = messageLocalization.format(this.component.NAME + TOOLBAR_ARIA_LABEL);
121121
const $toolbar = $('<div>').attr('aria-label', label).appendTo($headerPanel);
122-
this._toolbar = this._createComponent($toolbar, Toolbar, this._toolbarOptions!);
122+
this._toolbar = this._createComponent($toolbar, Toolbar, this._toolbarOptions);
123123
} else {
124124
this._toolbar.option(this._toolbarOptions!);
125125
}

packages/devextreme/js/__internal/grids/grid_core/m_types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export interface InternalGrid extends GridBaseType {
6262
_createComponent: <TComponent extends Component<any>>(
6363
$container: dxElementWrapper,
6464
component: new (...args) => TComponent,
65-
options: TComponent extends Component<infer TOptions> ? TOptions : never
65+
options?: TComponent extends Component<infer TOptions> ? TOptions : never
6666
) => TComponent;
6767
}
6868

0 commit comments

Comments
 (0)