Skip to content

Commit 9dce8d8

Browse files
Collection.Base: convert to ES6 Class (#28762)
1 parent b34e6c8 commit 9dce8d8

27 files changed

+809
-561
lines changed

packages/devextreme/js/__internal/core/widget/widget.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { extend } from '@js/core/utils/extend';
1616
import { each } from '@js/core/utils/iterator';
1717
import { isDefined, isPlainObject } from '@js/core/utils/type';
1818
import { compare as compareVersions } from '@js/core/utils/version';
19+
import type { DxEvent } from '@js/events';
1920
import { focusable as focusableSelector } from '@js/ui/widget/selectors';
2021
import type { WidgetOptions } from '@js/ui/widget/ui.widget';
2122

@@ -47,14 +48,14 @@ export interface Properties<TComponent = any> extends WidgetOptions<TComponent>
4748
class Widget<
4849
TProperties extends Properties = Properties,
4950
> extends DOMComponent<Widget<TProperties>, TProperties> {
50-
private readonly _feedbackHideTimeout = 400;
51+
public _activeStateUnit!: string;
52+
53+
public _feedbackHideTimeout = 400;
5154

5255
private readonly _feedbackShowTimeout = 30;
5356

5457
private _contentReadyAction?: ((event?: Record<string, unknown>) => void) | null;
5558

56-
private readonly _activeStateUnit!: string;
57-
5859
private _keyboardListenerId?: string | null;
5960

6061
private _isReady?: boolean;
@@ -265,8 +266,9 @@ class Widget<
265266
return this._getActiveElement();
266267
}
267268

268-
_isFocusTarget(element: Element): boolean {
269+
_isFocusTarget(element: Element | undefined): boolean {
269270
const focusTargets = $(this._focusTarget()).toArray();
271+
// @ts-expect-error ts-error
270272
return focusTargets.includes(element);
271273
}
272274

@@ -306,7 +308,7 @@ class Widget<
306308
}
307309

308310
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
309-
_focusInHandler(event): void {
311+
_focusInHandler(event: DxEvent): void {
310312
if (!event.isDefaultPrevented()) {
311313
this._createActionByOption('onFocusIn', {
312314
beforeExecute: () => this._updateFocusState(event, true),
@@ -316,7 +318,7 @@ class Widget<
316318
}
317319

318320
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
319-
_focusOutHandler(event): void {
321+
_focusOutHandler(event: DxEvent): void {
320322
if (!event.isDefaultPrevented()) {
321323
this._createActionByOption('onFocusOut', {
322324
beforeExecute: () => this._updateFocusState(event, false),

packages/devextreme/js/__internal/ui/calendar/m_calendar.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ const SELECTION_STRATEGIES = {
7474

7575
// @ts-expect-error
7676
const Calendar = Editor.inherit({
77-
_activeStateUnit: `.${CALENDAR_CELL_CLASS}`,
78-
7977
_getDefaultOptions() {
8078
return extend(this.callBase(), {
8179

@@ -442,6 +440,8 @@ const Calendar = Editor.inherit({
442440

443441
_init() {
444442
this.callBase();
443+
444+
this._activeStateUnit = `.${CALENDAR_CELL_CLASS}`;
445445
this._initSelectionStrategy();
446446
this._correctZoomLevel();
447447
this._initCurrentDate();

packages/devextreme/js/__internal/ui/collection/async.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import CollectionWidgetAsync from '@js/ui/collection/ui.collection_widget.async';
2-
import type { CollectionWidgetOptions, ItemLike } from '@js/ui/collection/ui.collection_widget.base';
2+
import type { ItemLike } from '@js/ui/collection/ui.collection_widget.base';
3+
import type { CollectionWidgetBaseProperties } from '@ts/ui/collection/m_collection_widget.base';
34

45
import CollectionWidgetEdit from './edit';
56

67
declare class Async<
78
// eslint-disable-next-line @typescript-eslint/no-explicit-any
8-
TProperties extends CollectionWidgetOptions<any, TItem, TKey>,
9+
TProperties extends CollectionWidgetBaseProperties<any, TItem, TKey>,
910
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1011
TItem extends ItemLike = any,
1112
// eslint-disable-next-line @typescript-eslint/no-explicit-any

packages/devextreme/js/__internal/ui/collection/base.ts

Lines changed: 0 additions & 97 deletions
This file was deleted.

packages/devextreme/js/__internal/ui/collection/edit.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import type { dxElementWrapper } from '@js/core/renderer';
2-
import type { CollectionWidgetOptions, ItemLike } from '@js/ui/collection/ui.collection_widget.base';
2+
import type { ItemLike } from '@js/ui/collection/ui.collection_widget.base';
33
import CollectionWidgetEdit from '@js/ui/collection/ui.collection_widget.edit';
4-
5-
import CollectionWidgetBase from './base';
4+
import type { CollectionWidgetBaseProperties } from '@ts/ui/collection/m_collection_widget.base';
5+
import CollectionWidgetBase from '@ts/ui/collection/m_collection_widget.base';
66

77
declare class Edit<
88
// eslint-disable-next-line @typescript-eslint/no-explicit-any
9-
TProperties extends CollectionWidgetOptions<any, TItem, TKey>,
9+
TProperties extends CollectionWidgetBaseProperties<any, TItem, TKey>,
1010
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1111
TItem extends ItemLike = any,
1212
// eslint-disable-next-line @typescript-eslint/no-explicit-any

packages/devextreme/js/__internal/ui/collection/live_update.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
import type { CollectionWidgetOptions, ItemLike } from '@js/ui/collection/ui.collection_widget.base';
1+
import type { ItemLike } from '@js/ui/collection/ui.collection_widget.base';
22
import CollectionWidgetLiveUpdate from '@js/ui/collection/ui.collection_widget.live_update';
3+
import type { CollectionWidgetBaseProperties } from '@ts/ui/collection/m_collection_widget.base';
34

45
import CollectionWidgetAsync from './async';
56

67
declare class LiveUpdate<
78
// eslint-disable-next-line @typescript-eslint/no-explicit-any
8-
TProperties extends CollectionWidgetOptions<any, TItem, TKey>,
9+
TProperties extends CollectionWidgetBaseProperties<any, TItem, TKey>,
910
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1011
TItem extends ItemLike = any,
1112
// eslint-disable-next-line @typescript-eslint/no-explicit-any

0 commit comments

Comments
 (0)