Only check functions for source module

Author: callumforrester

src/blueapi/utils/modules.py

@@ -37,7 +37,7 @@ def get_named_subset(names: list[str]):
                 yield value
 
 
-def is_sourced_from_module(obj: Any, module: ModuleType) -> bool:
+def is_function_sourced_from_module(obj: Any, module: ModuleType) -> bool:
     """
     Check if an object is originally from a particular module, useful to detect
     whether it actually comes from a nested import.
@@ -46,4 +46,6 @@ def is_sourced_from_module(obj: Any, module: ModuleType) -> bool:
         obj: Object to check
         module: Module to check against object
     """
-    return importlib.import_module(obj.__module__) is module
+    return (
+        hasattr(obj, "__module__") and importlib.import_module(obj.__module__) is module
+    )

tests/unit_tests/utils/functions_a.py

@@ -0,0 +1,4 @@
+def a(): ...
+
+
+def b(): ...

tests/unit_tests/utils/functions_b.py

@@ -0,0 +1,7 @@
+def c(): ...
+
+
+def d(): ...
+
+
+e = 1

tests/unit_tests/utils/test_modules.py

@@ -1,6 +1,6 @@
 from importlib import import_module
 
-from blueapi.utils import load_module_all
+from blueapi.utils import is_sourced_from_module, load_module_all
 
 
 def test_imports_all():
@@ -11,3 +11,18 @@ def test_imports_all():
 def test_imports_everything_without_all():
     module = import_module(".lacksall", package="tests.unit_tests.utils")
     assert list(load_module_all(module)) == [3, "hello", 9]
+
+
+def test_source_is_in_module():
+    module = import_module(".functions_b", package="tests.unit_tests.utils")
+    assert is_sourced_from_module(module.__dict__["c"], module)
+
+
+def test_source_is_not_in_module():
+    module = import_module(".functions_b", package="tests.unit_tests.utils")
+    assert not is_sourced_from_module(module.__dict__["a"], module)
+
+
+def test_source_check_on_non_function():
+    module = import_module(".functions_b", package="tests.unit_tests.utils")
+    assert not is_sourced_from_module(module.__dict__["e"], module)