Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass visit ID to blueapi where appropriate #793

Open
callumforrester opened this issue Jan 22, 2025 · 2 comments · May be fixed by #832
Open

Pass visit ID to blueapi where appropriate #793

callumforrester opened this issue Jan 22, 2025 · 2 comments · May be fixed by #832
Assignees
@DiamondJoseph

Comments

@callumforrester
Copy link
Contributor

callumforrester commented Jan 22, 2025 •
edited
Loading

For #552 blueapi needs visit ID

Acceptance Criteria

  • Can pass a visit ID with a plan request
  • If required to run plan and not supplied, error
@callumforrester
Copy link
Contributor Author

Should consult with SIMS on what to call a visit

@callumforrester
Copy link
Contributor Author

We're not requiring CLI integration for this ticket, it may be useful for testing as the assignee develops, or it may be onerous and should be turned into another ticket. Left to developer discretion.

@DiamondJoseph DiamondJoseph self-assigned this Feb 21, 2025
@DiamondJoseph DiamondJoseph linked a pull request Feb 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiamondJoseph DiamondJoseph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass visit id when starting task DiamondLightSource/blueapi
2 participants
@callumforrester @DiamondJoseph