Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct response message to client #35

Open
5 tasks
AmoebaProtozoa opened this issue Aug 13, 2021 · 0 comments
Open
5 tasks

Correct response message to client #35

AmoebaProtozoa opened this issue Aug 13, 2021 · 0 comments

Comments

@AmoebaProtozoa
Copy link

Development Task

Description

Before Postgres sends data result back to client, it will first give description about the data it’s returning, aka Row description. After sending the data row, it will send a command completion along with a tag tells user how many rows has been modified.
Currently, both our row description and data row information are incomplete/ incorrect. This issue address that.

Which Module

Server

Task List

  • Column Index in row description message
  • Column Length in row description message
  • Type Modifier in row description message
  • Tag in command completion message
  • Add Unit Test in conn_test for all the fields above

Reference

Below are our current response message when running simple select statement on TiDB for PG
F8BE0240-8335-41C7-81FB-62AF0F21666F
Here are the expected message captured from Postgres 12
7B1FAEC5-0D96-44D0-A9FA-F2BDA6FCB717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant