Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: reconciliation and cell merging #12

Open
demery opened this issue Jan 21, 2022 · 0 comments
Open

Bug: reconciliation and cell merging #12

demery opened this issue Jan 21, 2022 · 0 comments

Comments

@demery
Copy link

demery commented Jan 21, 2022

Bug 1:

@lpcoladangelo discovered that reconciliation is more reliable if a recon column is created from a multi-valued cell and then the recon column is split (rather than split the source column and then creating the recon column). This mitigates a problem in OpenRefine 3.5.1, where names in the recon column are not reconciled and no option is available to search for a matching value.

@demery found that in Safari, OpenRefine 3.5.1 still returned unreconciled values without the "Search for a match" button, but the problem did not occur in Chrome.

This change, splitting the "recon" column rather than the source column should be applied to former owner and authors.

Bug 2:

The current method for merging qid-human with qid-organization and instance of-human with instance of-organization doesn't work. We want to grab the first non-blank value, but we're using coalesce which returns the first non-null value; because blank values (the empty string) aren't null, coalesce won't work:

coalesce("", "a value") // => ""

We want a value to be returned. To find non-blank values we need to use if() and isBlank().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant