Skip to content

Commit ad0dbf5

Browse files
authored
Only show search results from the current version of the docs (#396)
1 parent e6689e8 commit ad0dbf5

File tree

2 files changed

+38
-12
lines changed

2 files changed

+38
-12
lines changed

src/components/nav.rs

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,22 +194,44 @@ fn SearchModal() -> Element {
194194
let (bytes, _) =
195195
dioxus_search::yazi::decompress(&data, dioxus_search::yazi::Format::Zlib).ok()?;
196196

197-
let index = dioxus_search::SearchIndex::from_bytes("search", bytes);
197+
let index: dioxus_search::SearchIndex<Route> =
198+
dioxus_search::SearchIndex::from_bytes("search", bytes);
198199

199200
Some(index)
200201
});
201202

202203
let search = move || {
203204
let query = &search_text.read();
204-
search_index
205+
let mut results = search_index
205206
.value()
206207
.as_ref()
207-
.map(|search| search.as_ref().map(|s| s.search(query)))
208-
.flatten()
209-
.unwrap_or_else(|| Ok(vec![]))
208+
.and_then(|search| search.as_ref().map(|s| s.search(query)))
209+
.unwrap_or_else(|| Ok(vec![]));
210+
let current_route: Route = router().current();
211+
212+
// Only show search results from the version of the docs the user is currently on (or the latest if they
213+
// are not on a doc page)
214+
if let Ok(results) = &mut results {
215+
results.retain(|result| {
216+
// If the user is not on a doc page, show only the latest docs
217+
if !current_route.is_docs() {
218+
return result.route.is_latest_docs();
219+
}
220+
// Otherwise, show the results from the current version of the docs
221+
matches!(
222+
(&current_route, &result.route),
223+
(Route::Docs06 { .. }, Route::Docs06 { .. })
224+
| (Route::Docs05 { .. }, Route::Docs05 { .. })
225+
| (Route::Docs04 { .. }, Route::Docs04 { .. })
226+
| (Route::Docs03 { .. }, Route::Docs03 { .. })
227+
)
228+
});
229+
}
230+
231+
results
210232
};
211233

212-
let mut results = use_signal(|| search());
234+
let mut results = use_signal(search);
213235

214236
let mut last_key_press = use_signal(|| {
215237
if cfg!(target_arch = "wasm32") {

src/docs.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,21 @@ impl CurrentDocsVersion {
2828
}
2929
}
3030

31-
pub fn use_current_docs_version() -> CurrentDocsVersion {
31+
pub fn use_try_current_docs_version() -> Option<CurrentDocsVersion> {
3232
let route = use_route();
3333
match route {
34-
Route::Docs06 { child } => CurrentDocsVersion::V06(child),
35-
Route::Docs05 { child } => CurrentDocsVersion::V05(child),
36-
Route::Docs04 { child } => CurrentDocsVersion::V04(child),
37-
Route::Docs03 { child } => CurrentDocsVersion::V03(child),
38-
_ => panic!("current docs version should be set"),
34+
Route::Docs06 { child } => Some(CurrentDocsVersion::V06(child)),
35+
Route::Docs05 { child } => Some(CurrentDocsVersion::V05(child)),
36+
Route::Docs04 { child } => Some(CurrentDocsVersion::V04(child)),
37+
Route::Docs03 { child } => Some(CurrentDocsVersion::V03(child)),
38+
_ => None,
3939
}
4040
}
4141

42+
pub fn use_current_docs_version() -> CurrentDocsVersion {
43+
use_try_current_docs_version().expect("current docs version should be set")
44+
}
45+
4246
pub trait AnyBookRoute: Routable + PartialEq + Hash + Eq + Clone + Copy {
4347
fn sections(&self) -> &[use_mdbook::mdbook_shared::Section];
4448
fn page(&self) -> &use_mdbook::mdbook_shared::Page<Self>;

0 commit comments

Comments
 (0)