Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product_count is not indexed #54

Open
Ogek opened this issue May 20, 2020 · 0 comments
Open

product_count is not indexed #54

Ogek opened this issue May 20, 2020 · 0 comments

Comments

@Ogek
Copy link

Ogek commented May 20, 2020

Introduction

I noticed that in VSF code there is a check for excluding categories that have children_count <= 0 and product_count <= 0.
I think this is necessary in order to remove all the categories that are empty.
https://github.com/DivanteLtd/vue-storefront/blob/6cd57ab269a8a31ed8eb5a18ebc8934abe1b9b55/src/themes/default/components/core/blocks/SidebarMenu/SidebarMenu.vue#L204

Issue

The problem is that this indexer doesn't seem to take product_count in consideration so if a category haven't children categories but only products, it will be hidden by VSF.

Proposal

Index product_count field value to ES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant